Skip to content

Commit 0617bcb

Browse files
committed
Update test suite & clue/phar-composer to avoid build error on Windows
1 parent a949565 commit 0617bcb

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66

77
jobs:
88
PHPUnit:
9+
name: PHPUnit (PHP ${{ matrix.php }} on ${{ matrix.os }})
910
runs-on: ${{ matrix.os }}
1011
strategy:
1112
matrix:
@@ -25,19 +26,15 @@ jobs:
2526
- 5.4
2627
steps:
2728
- uses: actions/checkout@v2
28-
- name: Setup PHP
29-
uses: shivammathur/setup-php@v2
29+
- uses: shivammathur/setup-php@v2
3030
with:
3131
php-version: ${{ matrix.php }}
3232
extensions: sqlite3
33+
coverage: xdebug
3334
- run: composer install
3435
- run: vendor/bin/phpunit --coverage-text
3536
if: ${{ matrix.php >= 7.3 }}
3637
- run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
3738
if: ${{ matrix.php < 7.3 }}
3839
- run: cd tests/install-as-dep && composer install && php query.php
39-
- run: cd tests/install-as-dep && php -d phar.readonly=0 vendor/bin/phar-composer build . query.phar
40-
continue-on-error: ${{ matrix.os == 'windows-2019' }}
41-
id: phar
42-
- run: php tests/install-as-dep/query.phar
43-
if: ${{ steps.phar.outcome == 'success' }}
40+
- run: cd tests/install-as-dep && php -d phar.readonly=0 vendor/bin/phar-composer build . query.phar && php query.phar

tests/install-as-dep/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"clue/reactphp-sqlite": "*@dev"
44
},
55
"require-dev": {
6-
"clue/phar-composer": "^1.0"
6+
"clue/phar-composer": "^1.4"
77
},
88
"bin": [
99
"query.php"

0 commit comments

Comments
 (0)