Improve mkdocs instructions to build docs with correct directory permissions and allow using SIGINT to stop #298
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
mkdocs-instructions
branch
from
ad5b811 to
3b6f87f
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves the mkdocs documentation build instructions by adding support for graceful shutdown with SIGINT, ensuring proper directory permissions, and adding automatic container cleanup.
Changes:
- Added SIGINT signal handler to the mkdocs service for graceful shutdown with Ctrl+C
- Updated build commands to create the build directory before running and clean up containers automatically with
--rm - Added explicit
docker compose pullstep in CI workflow to ensure latest image
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/compose.yaml | Added stop_signal: SIGINT to enable graceful shutdown with Ctrl+C |
| docs/README.md | Updated build command to create directory first and auto-cleanup with --rm flag |
| .github/workflows/ci.yml | Added explicit pull step and updated build command with directory creation and auto-cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clue
force-pushed
the
mkdocs-instructions
branch
from
3b6f87f to
0868eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #271 and clue/framework-x-website#43