Skip to content

Conversation

@clue
Copy link
Owner

@clue clue commented Aug 19, 2025

This changeset improves PHP 8.5+ support by updating to Promise v3.3 and avoiding deprecated setAccessible() calls in tests. With these changes applied, tests against the current PHP 8.5 RC pass without errors.

Builds on top of reactphp/promise#264, #281, #265, #267 and others
Refs https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible and php/php-src#19273

@clue clue added this to the v0.18.0 milestone Aug 19, 2025
@clue clue requested a review from Copilot August 19, 2025 21:29
@clue clue added the new feature New feature or request label Aug 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves PHP 8.5+ compatibility by updating the React/Promise dependency to version 3.3 and wrapping deprecated setAccessible() calls in conditional checks based on PHP version. The changes ensure tests pass without deprecation warnings on PHP 8.5 RC.

  • Updates React/Promise dependency from ^3.2 to ^3.3 for better PHP 8.5 support
  • Adds PHP version checks around setAccessible() calls to avoid deprecation warnings
  • Maintains backward compatibility with older PHP versions while supporting PHP 8.5+

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
composer.json Updates react/promise dependency to version 3.3
tests/Io/RouteHandlerTest.php Wraps setAccessible() calls with PHP version checks
tests/Io/ReactiveHandlerTest.php Wraps setAccessible() calls with PHP version checks
tests/Io/LogStreamHandlerTest.php Wraps setAccessible() calls with PHP version checks
tests/ErrorHandlerTest.php Wraps setAccessible() calls with PHP version checks
tests/AppTest.php Wraps setAccessible() calls with PHP version checks
tests/AppMiddlewareTest.php Wraps setAccessible() calls with PHP version checks
tests/AccessLogHandlerTest.php Wraps setAccessible() calls with PHP version checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant