Run tests on PHP 8.4 and update test environment

clue · clue · commit 0a0014a3eff5 · 2025-01-02T09:13:56.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,9 +11,11 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-22.04
+          - ubuntu-24.04
           - windows-2022
         php:
+          - 8.4
+          - 8.3
           - 8.2
           - 8.1
           - 8.0
@@ -36,8 +38,6 @@ jobs:
           extensions: sqlite3
           coverage: xdebug
           ini-file: development
-          # disable JIT on PHP 8.2 with Xdebug: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.
-          ini-values: ${{ matrix.php == 8.2 && 'opcache.jit_buffer_size=0' || '' }}
       - run: composer install
       - run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml
         if: ${{ matrix.php >= 7.3 }}
diff --git a/tests/FunctionalFactoryTest.php b/tests/FunctionalFactoryTest.php
@@ -52,7 +52,7 @@ public function testOpenReturnsPromiseWhichFulfillsWithConnectionForMemoryPathAn
     public function testOpenReturnsPromiseWhichRejectsWithExceptionWhenPathIsInvalid()
     {
         $factory = new Factory();
-        $promise = $factory->open('/dev/foobar');
+        $promise = $factory->open('/dev/foo/bar');
 
         $promise->then(function (DatabaseInterface $db) {
             echo 'open.';
diff --git a/tests/Io/BlockingDatabaseTest.php b/tests/Io/BlockingDatabaseTest.php
@@ -15,7 +15,7 @@ public function testCtorThrowsForInvalidPath()
             // legacy PHPUnit
             $this->setExpectedException('Exception');
         }
-        new BlockingDatabase('/dev/foobar');
+        new BlockingDatabase('/dev/foo/bar');
     }
 
     public function testExecReturnsRejectedPromiseForInvalidQuery()

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function testOpenReturnsPromiseWhichFulfillsWithConnectionForMemoryPathAn`
`52`	`52`	`public function testOpenReturnsPromiseWhichRejectsWithExceptionWhenPathIsInvalid()`
`53`	`53`	`{`
`54`	`54`	`$factory = new Factory();`
`55`		`- $promise = $factory->open('/dev/foobar');`
	`55`	`+ $promise = $factory->open('/dev/foo/bar');`
`56`	`56`
`57`	`57`	`$promise->then(function (DatabaseInterface $db) {`
`58`	`58`	`echo 'open.';`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public function testCtorThrowsForInvalidPath()`
`15`	`15`	`// legacy PHPUnit`
`16`	`16`	`$this->setExpectedException('Exception');`
`17`	`17`	`}`
`18`		`- new BlockingDatabase('/dev/foobar');`
	`18`	`+ new BlockingDatabase('/dev/foo/bar');`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`public function testExecReturnsRejectedPromiseForInvalidQuery()`