Skip to content

feat: improve Options definition #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

feat: improve Options definition #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/agentic/option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*

Check failure on line 1 in components/agentic/option.go

View workflow job for this annotation

GitHub Actions / eino-unit-test

File test coverage below threshold 

File test coverage below threshold: coverage:  0.0% (0/29); threshold: 20%
* Copyright 2025 CloudWeGo Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -23,11 +23,11 @@
// Options is the common options for the model.
type Options struct {
// Temperature is the temperature for the model, which controls the randomness of the model.
Temperature *float32
Temperature *float64
// Model is the model name.
Copy link

@github-actions github-actions bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Breaking API Changes Detected

Package: github.com/cloudwego/eino/components/agentic

Incompatible changes:

  • Options.Temperature: changed from *float32 to *float64
  • Options.TopP: changed from *float32 to *float64
  • WithTemperature: changed from func(float32) Option to func(float64) Option
  • WithTopP: changed from func(float32) Option to func(float64) Option
Review Guidelines

Please ensure that:

  • The changes are absolutely necessary
  • They are properly documented
  • Migration guides are provided if needed

⚠️ Please resolve this thread after reviewing the breaking changes.

Model *string
// TopP is the top p for the model, which controls the diversity of the model.
TopP *float32
TopP *float64
// Tools is a list of tools the model may call.
Tools []*schema.ToolInfo
// ToolChoice controls which tool is called by the model.
Expand All @@ -42,7 +42,7 @@
}

// WithTemperature is the option to set the temperature for the model.
func WithTemperature(temperature float32) Option {
func WithTemperature(temperature float64) Option {
return Option{
apply: func(opts *Options) {
opts.Temperature = &temperature
Expand All @@ -60,7 +60,7 @@
}

// WithTopP is the option to set the top p for the model.
func WithTopP(topP float32) Option {
func WithTopP(topP float64) Option {
return Option{
apply: func(opts *Options) {
opts.TopP = &topP
Expand Down
Loading