-
Notifications
You must be signed in to change notification settings - Fork 644
feat(agentic): define AgenticModel component interface #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0788f09 to
19d3bb9
Compare
d9473db to
ef740c2
Compare
555d774 to
39698ce
Compare
schema/agentic_message.go
Outdated
|
|
||
| type BlockReasoning struct { | ||
| // SummaryIndex is the index of the ReasoningSummary delta is associated with. | ||
| SummaryIndex *int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个和 ContentBlock 中的 Index 和 State 重复了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SummaryIndex 是给 Reasoning Block 中的 Summary array 用的,ContentBlock 是给 Block 用的
| SummaryIndex *int | ||
|
|
||
| // Summary is the reasoning content summary. | ||
| Summary []*ReasoningSummary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content 是模型 cot 过程,会包含 developer instruction 信息。summary 是可以直接透出给终端用户的思考内容。
https://cookbook.openai.com/articles/gpt-oss/handle-raw-cot
schema/agentic_message.go
Outdated
| } | ||
|
|
||
| type BaseGeneratedTextAnnotation interface { | ||
| AnnotationProvider() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
咱们没有暴露过 Provider/Vendor 概念。这个需要改一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base 和 Generated 应该都不需要了
接口就表达了是 Base
已经处在 GenText Block 了,不用再冗余表达 Generated 了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer name: TextAnnotation
schema/agentic_message.go
Outdated
| type BlockAssistantGenText struct { | ||
| Text string | ||
|
|
||
| Annotations []BaseGeneratedTextAnnotation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
既然把 Annotations 抽象成接口了,没必要在这里限定成数组了。
更详细定义的 GetTextURLCitation 接口的返回,决定是数组,还是 map
886c0bd to
c8580de
Compare
schema/agentic_message.go
Outdated
| // Index is used for streaming to identify the chunk of the block for merging. | ||
| Index *int | ||
| // Streaming event type of this block. | ||
| EventType *StreamEventType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT 推荐:Stage *StreamStage
24eeda0 to
13259c3
Compare
13259c3 to
a01b5d5
Compare

What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: