Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lakeformation PrincipalPermissions and Permissions incorrectly have the same ResourceProperty #2073

Closed
mumblepins opened this issue Sep 1, 2022 · 1 comment · Fixed by #2088
Closed

Lakeformation PrincipalPermissions and Permissions incorrectly have the same ResourceProperty #2073

mumblepins opened this issue Sep 1, 2022 · 1 comment · Fixed by #2088

Comments

@mumblepins
Copy link
Contributor

AWS::LakeFormation::Permissions Resource and AWS::LakeFormation::PrincipalPermissions Resource have different attributes, but are treated identically in Troposphere.

I'm guessing that lakeformation.PrincipalPermissions and lakeformation.Permissions should probably reference different ResourceProperty classes.
@markpeek markpeek mentioned this issue Oct 24, 2022
Merged
@markpeek
Copy link
Member

@mumblepins can you review this fix #2088?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lakeformation: remove ResourceProperty naming conflict cloudtools/troposphere
2 participants
@markpeek @mumblepins