-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Support customer icon for ButtonDropdown icon variants #2639
Comments
Hey @phuctm97 |
For example: I have a "Settings" dropdown, a Settings icon would look a lot better and is more recognizable than an ellipsis. |
+1. I'm actually curious why maintainers feel the request requires explanation why ellipsis icon not suitable. There are times, for example, a hamburger icon my be more suitable than ellipse. Also. afaict, Cloudscape does not provide a general purpose popover menu control, so this is all we have to work with and ellipse-only forces hand to pull in alternate component libraries to fill the gap. |
It is done this way for consistency. It is a single familiar shape, all users know what happens when clicking on it, no side effects attached. With custom icons, it becomes unpredictable experience. If we add configurable icon, the very next feature request will be to add tooltip, because various icons are confusing. We will add tooltip – more corner cases will show up and need addressing. Why going all this way if we can keep the UI plain and simple with consistent icons? |
This makes sense but I feel like a couple extra options would a good balance without compromising consistency so much. |
Sure, we can discuss, which one of our icons could be useful there without compromising consistency |
Description
Currently when ButtonDropdown is set to variant
icon
orinline-icon
, the icon is hard-coded to be the ellipsis icon. It would be great if we can customize the icon as well (by acceptingiconName
,iconUrl
, etc.)Code of Conduct
The text was updated successfully, but these errors were encountered: