Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Expose Popover Dismiss Trigger #1995

Open
2 tasks done
vs-amzn opened this issue Feb 21, 2024 · 3 comments
Open
2 tasks done

[Feature Request]: Expose Popover Dismiss Trigger #1995

vs-amzn opened this issue Feb 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@vs-amzn
Copy link

vs-amzn commented Feb 21, 2024

Description

Have been working with popups and noticed that the only way to dismiss a Popup is by either

  1. Clicking out of the popover
  2. Clicking on the dismissButton (if it's enabled)

Was hoping there could be a way to toggle the popover display by clicking the button that triggers the popover. So essentially support for customizing when we display the popover.

Code of Conduct

@vs-amzn vs-amzn added the enhancement New feature or request label Feb 21, 2024
@rubencarvalho
Copy link
Contributor

Hello,

Thank you for submitting the feature request. Implementing this pattern would result in inconsistencies across the user experience. Could you provide more details about your use case?

Thank you.

@vs-amzn
Copy link
Author

vs-amzn commented Feb 23, 2024

Thanks for getting back.

Essentially I'd like to be able to toggle on/off the popover onclick of the button that generates the popover.

@kaikno
Copy link
Contributor

kaikno commented Mar 23, 2024

I understand your point and share your irritation regarding the popover's persistence without any user interaction.

In addition, an argument that counters inconsistency is the fact that a chart popover can also be dismissed by re-clicking the chart.

A new idea i have is to enable its disappearance after a certain period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants