feat: Change default registry #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Nov 21, 2023
|
Closing as probably not needed. |
|
Reopening as some parts are needed, and other parts are nice to have and/or good for feature parity. |
disq
commented
Nov 21, 2023
| client, err := NewClient(ctx, typ, spec, opts...) | ||
| if err != nil { | ||
| return nil, err | ||
| return clients, err // previous entries in clients determine which plugins were successfully created |
There was a problem hiding this comment.
This is needed so that we can check which client has failed by looking at len(clients)
disq
force-pushed
the
feat/change-default-registry
branch
2 times, most recently
from
116998b
to
aa0f3c5
Compare
disq
force-pushed
the
feat/change-default-registry
branch
from
4161f7b
to
eeb1bac
Compare
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Nov 22, 2023
…egistry: github` (#15409) Uses ~cloudquery/plugin-pb-go#170 cloudquery/plugin-pb-go#172 (now tagged as 1.14.2) Part of cloudquery/cloudquery-issues#924 (Internal issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to be done with pointers because if a value is not specified it doesn't enter intoUnmarshal()for that type, so short of changing the zero value to be CloudQuery (or using strings) we can't do it any other way. Tried withRegistryUnset(-1) doesn't really work with unspecified fields.Will follow up with the CLI counterpart later.
Part of https://github.com/cloudquery/cloudquery-issues/issues/924 (Internal issue)