SNS Topic Policy duplicated

[ghost]

Found a bug? Maybe our Slack Community can help.

Describe the Bug

The module is trying to attach an SNS policy here https://github.com/cloudposse/terraform-aws-guardduty/blob/master/main.tf#L35 but the SNS topic in the module here https://github.com/cloudposse/terraform-aws-guardduty/blob/master/main.tf#L14 already has a policy attached https://github.com/cloudposse/terraform-aws-sns-topic/blob/master/main.tf#L40, so always the plan is showing the following:

 # module.pave-guardduty.module.guardduty.aws_sns_topic_policy.sns_topic_publish_policy[0] has been changed
  ~ resource "aws_sns_topic_policy" "sns_topic_publish_policy" {
        id     = "arn:aws:sns:us-east-1:361452620376:pavedev-us-east-1-pave-us-east-1-guardduty-guardduty"
      ~ policy = jsonencode(
          ~ {
              ~ Id        = "GuardDutyPublishToSNS" -> "SNSTopicsPub"
                # (2 unchanged elements hidden)
            }
        )
        # (2 unchanged attributes hidden)
    }
  # module.pave-guardduty.module.guardduty.module.sns_topic[0].aws_sns_topic.this has been changed
  ~ resource "aws_sns_topic" "this" {
        id                                       = "arn:aws:sns:us-east-1:361452620376:pavedev-us-east-1-pave-us-east-1-guardduty-guardduty"
        name                                     = "pavedev-us-east-1-pave-us-east-1-guardduty-guardduty"
      ~ policy                                   = jsonencode(
          ~ {
              ~ Id        = "GuardDutyPublishToSNS" -> "SNSTopicsPub"
                # (2 unchanged elements hidden)
            }
        )
        tags                                     = {
            "Attributes"  = "guardduty"
            "Environment" = "us-east-1"
            "Name"        = "pavedev-us-east-1-pave-us-east-1-guardduty-guardduty"
            "Namespace"   = "pavedev"
        }
        # (12 unchanged attributes hidden)
    }

Expected Behavior

We should just define one policy of pass to the SNS module the arn of the policy that is being created here.

Anything that will help us triage the bug will help. Here are some ideas:

• OS: [e.g. Linux, OSX, WSL, etc]
• Version [e.g. 10.15]

Additional Context

Add any other context about the problem here.

[kierang-contino]

As far as I can tell, this should be resolved by the SNS Topic module version 0.20.1.