Skip to content

Conversation

@florian0410
Copy link
Contributor

what

why

  • When deploying an empty environment (no application package deployed), AWS deploy a basic app. Its default process healthcheck is pointing to "/" in that case and not "/healthcheck".
  • During many test, I got the situation where I wanted to update my environment without application just for testing. In the end, i forgot to setup this healthcheck value and lost a lot of time since I had to wait for beanstalk timeout. It does not occurs on first deployment it seems.

Note

I'm not sure if we also deploy an application package for the tests, in that module, I should add the default value to var file else.

@florian0410 florian0410 marked this pull request as ready for review August 27, 2021 09:28
@florian0410 florian0410 requested a review from a team as a code owner August 27, 2021 09:28
@florian0410 florian0410 requested a review from a team as a code owner August 27, 2021 09:28
@florian0410 florian0410 requested review from Makeshift and woz5999 and removed request for a team August 27, 2021 09:28
@florian0410
Copy link
Contributor Author

/test all

@nitrocode nitrocode merged commit bcbb673 into master Aug 27, 2021
@nitrocode nitrocode deleted the feat/healthcheck_default branch August 27, 2021 15:22
@nitrocode nitrocode added the patch A minor, backward compatible change label Aug 27, 2021
@nitrocode
Copy link
Member

I forgot that this module is in a code freeze due to the sg module refactoring so after I merged this, I set the new release as a pre-release.

cloudposse/terraform-aws-security-group#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch A minor, backward compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants