Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the SSHSourceRestriction setting. #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bring back the SSHSourceRestriction setting. #124

wants to merge 1 commit into from

Conversation

DangerDawson
Copy link

what

  • Bring back the SSHSourceRestriction

why

references

@DangerDawson
Bring back the SSHSourceRestriction setting.
9e74f2b 
This got removed in a previous commit.
@DangerDawson DangerDawson requested a review from a team as a code owner July 6, 2020 09:04
@DangerDawson DangerDawson requested review from Gowiem and adamcrews and removed request for a team July 6, 2020 09:04
@DangerDawson DangerDawson mentioned this pull request Jul 6, 2020
Open
@joe-niland
Copy link
Member

/test all

1 similar comment
@joe-niland
Copy link
Member

/test all

@joe-niland
Copy link
Member

/rebuild-readme

@joe-niland
Copy link
Member

@DangerDawson could you please rebuild the readme by running make readme or allow access to your branch?

@razorsedge
Copy link
Contributor

@joe-niland I am curious, what does a readme rebuild have to do with adding a single Beanstalk setting?

@joe-niland
Copy link
Member

@razorsedge technically nothing. Normally it's required when variables.tf is changed. In this case, the test is failing, perhaps because a previous PR was merged without making sure tests pass. We should fix it on this PR.

@joe-niland joe-niland self-assigned this Dec 7, 2020
@aknysh
Copy link
Member

aknysh commented Dec 31, 2021

@DangerDawson please resolve the conflicts

@nathant727
Copy link

How can I help to get this issue with ssh_source_restriction resolved?

@osterman
Copy link
Member

/rebuild-readme

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 9, 2024

Thanks @DangerDawson for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathant727 nathant727 nathant727 approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@adamcrews adamcrews Awaiting requested review from adamcrews

At least 1 approving review is required to merge this pull request.

Assignees

@joe-niland joe-niland

Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DangerDawson @joe-niland @razorsedge @aknysh @nathant727 @osterman @hans-d