Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just mask with eight stars #10

Open
brandonkal opened this issue Feb 4, 2020 · 1 comment
Open

Just mask with eight stars #10

brandonkal opened this issue Feb 4, 2020 · 1 comment

Comments

@brandonkal
Copy link

Why is the length of a secret included in the output? It would be better to mask with a set length list of repeated characters.

@osterman
Copy link
Contributor

I can see your point. In some ways it's perhaps more secure the conceal the length in addition to the characters. What I don't like about it is it conceals also bad values (e.g. empty strings or exceptionally short passwords).

I don't have a super strong opinion on this. If others would like it to work this way, wouldn't oppose a PR for it (ideally making it optional?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants