Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] subnetProvider #12

Open
4 tasks
helen-frank opened this issue Sep 20, 2024 · 2 comments · May be fixed by #28
Open
4 tasks

[WIP] subnetProvider #12

helen-frank opened this issue Sep 20, 2024 · 2 comments · May be fixed by #28

Comments

@helen-frank
Copy link
Contributor

helen-frank commented Sep 20, 2024

  • LivenessProbe
  • List
  • ZonalSubnetsForLaunch
  • UpdateInflightIPs

Dependencies: #11

type Provider interface {
	LivenessProbe(*http.Request) error
	List(context.Context, *v1.EC2NodeClass) ([]*ec2.Subnet, error)
	ZonalSubnetsForLaunch(context.Context, *v1.EC2NodeClass, []*cloudprovider.InstanceType, string) (map[string]*Subnet, error)
	UpdateInflightIPs(*ec2.CreateFleetInput, *ec2.CreateFleetOutput, []*cloudprovider.InstanceType, []*Subnet, string)
}
This was referenced Sep 20, 2024
@daimaxiaxie
Copy link
Contributor

daimaxiaxie commented Sep 24, 2024

This is somewhat different from AliCloud. The available IP addresses are related to the switch.

This might be better.

type Provider interface {
	LivenessProbe(*http.Request) error
	List(context.Context, *v1alpha1.ECSNodeClass) ([]*vpc.DescribeVSwitchesResponseBodyVSwitchesVSwitch, error)
	ZonalSubnetsForLaunch(context.Context, *v1alpha1.ECSNodeClass, []*cloudprovider.InstanceType, string) (map[string]*VSwitch, error)
	UpdateInflightIPs(*ecs.CreateAutoProvisioningGroupRequest, *ecs.DescribeInstancesResponseBodyInstances, []*cloudprovider.InstanceType, []*VSwitch, string)
}

Why not use ecs.CreateAutoProvisioningGroupResponse in UpdateInflightIPs?

  • The information in CreateAutoProvisioningGroupResponse is too little, which not only does not meet the requirements of SubnetProvider, but also does not meet the requirements of InstanceProvider.

@daimaxiaxie daimaxiaxie linked a pull request Sep 27, 2024 that will close this issue
@daimaxiaxie
Copy link
Contributor

I am a little confused about the name of Alibaba Cloud's VSwitch. It shows different names in different places. So I'm not sure which one is easier for users to understand.
Solicitation for naming:

  1. vSwitchSelectorTerms
spec:
  vSwitchSelectorTerms:
    - id: vsw-abc
    - tags: 
        - k: v
  1. vswitchSelectorTerms
spec:
  vswitchSelectorTerms:
    - id: vsw-abc
    - tags: 
        - k: v
  1. VSwitchSelectorTerms
spec:
  VSwitchSelectorTerms:
    - id: vsw-abc
  1. switchSelectorTerms
spec:
  switchSelectorTerms:
    - id: vsw-abc
  1. other

@jwcesign @helen-frank @IrisIris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants