Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Combine Organization controllers #681

Open
IvoGoman opened this issue Oct 29, 2024 · 0 comments
Open

[FEAT] - Combine Organization controllers #681

IvoGoman opened this issue Oct 29, 2024 · 0 comments
Labels

Comments

@IvoGoman
Copy link
Contributor

Priority

(Medium) I'm annoyed but I'll live

Description

The DexController, OrganizationController, RBACController, ServiceProxyController and TeamRoleSeederController are reconciling the Organization.

Currently there is a workaround in place to ensure they do not interfere with each other when setting the Ready condition on the Organization.
With this PR the Controllers should be combined into a single controller, with a flow such as:

flowchart TD
  A[Organization Namepace]
  B@{ shape: diamond, label: "Created?" }
  C[AdminTeam]
  D[Organization RBAC]
  E[ServiceProxy]
  F[TeamRoles]
  G[Dex Connector]
  H@{ shape: diamond, label: "OIDC Config?" }
  J@{ shape: diamond, label: "ServiceProxy PluginDefinition?" }

  I[Return ERROR]
  K[Return]

  A --> B
  B -->|Yes| D
  B -->|No| I
  D --> F
  F --> J
  J -->|Yes| E
  E --> H
  J -->|No| H
  H -->|Yes| G
  G --> C
  H -->|No| K
  C --> K
Loading

Each of the Steps should set a statusCondition on the Organization to track the status of the Organization resource.

Reference Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant