#137 Throw not found instead of internal error

Author: jelemux

pkg/adapter/kubernetes/blueprintcr/v3/blueprintSpecCRRepository.go

@@ -110,7 +110,11 @@ func (repo *blueprintSpecRepo) getMaskManifest(ctx context.Context, blueprintId
 	if blueprintCR.Spec.MaskSource.CrRef != nil {
 		blueprintMask, maskErr := repo.blueprintMaskClient.Get(ctx, blueprintCR.Spec.MaskSource.CrRef.Name, metav1.GetOptions{})
 		if maskErr != nil {
-			return nil, &domainservice.InternalError{WrappedError: maskErr, Message: fmt.Sprintf("could not get blueprint mask from ref %q in blueprint %q", blueprintCR.Spec.MaskSource.CrRef.Name, blueprintId)}
+			return nil, &domainservice.NotFoundError{
+				WrappedError: maskErr,
+				Message:      fmt.Sprintf("could not get blueprint mask from ref %q in blueprint %q", blueprintCR.Spec.MaskSource.CrRef.Name, blueprintId),
+				DoNotRetry:   false,
+			}
 		}
 
 		maskManifest = blueprintMask.Spec.BlueprintMaskManifest

pkg/adapter/kubernetes/blueprintcr/v3/blueprintSpecCRRepository_test.go

@@ -194,7 +194,7 @@ func Test_blueprintSpecRepo_GetById(t *testing.T) {
 
 		// then
 		require.Error(t, err)
-		var expectedErrorType *domainservice.InternalError
+		var expectedErrorType *domainservice.NotFoundError
 		assert.ErrorAs(t, err, &expectedErrorType)
 		assert.ErrorContains(t, err, fmt.Sprintf("could not get blueprint mask from ref %q in blueprint %q", "my-blueprint-mask", blueprintId))
 	})