CLOUDSTACK-9470: Fix for SshHelper - test_network_acl was failing on Vmware due to a bug in sshExecute, in which value returned was null and there was still stdout to consume. This fix addresses this problem, consuming stdout peoperly to return expected value in sshExecute

Author: nvazquez

utils/src/main/java/com/cloud/utils/ssh/SshHelper.java

@@ -22,6 +22,10 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang.StringUtils;
 
 import org.apache.log4j.Logger;
 
@@ -196,6 +200,16 @@ public static Pair<Boolean, String> sshExecute(String host, int port, String use
 
             String result = sbResult.toString();
 
+            if (StringUtils.isBlank(result)) {
+                try {
+                    result = IOUtils.toString(stdout, StandardCharsets.UTF_8);
+                }
+                catch (IOException e) {
+                    s_logger.error("Couldn't get content of input stream due to: " + e.getMessage());
+                    return new Pair<Boolean, String>(false, result);
+                }
+            }
+
             if (sess.getExitStatus() == null) {
                 //Exit status is NOT available. Returning failure result.
                 s_logger.error(String.format("SSH execution of command %s has no exit status set. Result output: %s", command, result));