Open
Conversation
cloudinary-pkoniu
requested review from
const-cloudinary and
pawelphilipczyk-cloudinary
pawelphilipczyk-cloudinary
approved these changes
Oct 17, 2023
pawelphilipczyk-cloudinary
left a comment
pawelphilipczyk-cloudinary
left a comment
There was a problem hiding this comment.
Looks ok but please see my comments.
const-cloudinary
approved these changes
Jan 23, 2025
| var imageFileData = handleImageFile(allowedParams.image_file); | ||
| return call_api('post', ['resources', 'visual_search'], { image_file: imageFileData }, callback, options); | ||
| } | ||
| return call_api('get', ['resources', 'visual_search'], allowedParams, callback, options); |
There was a problem hiding this comment.
You can perform the same post request in both cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
or
What Does This PR Address?
Are Tests Included?
Reviewer, Please Note:
I added the
requestsdependency because writing an http request with multi-part file upload using vanilla node is a complicated task and to be honest, I failed at that. I tried writing it from scratch and also reusing some components from the upload.js file but the way this sdk is designed does not allow reusing some of the functions there. At least not in an easy way that won't potentially mean a broken contract. Eventually, I'd prefer doing all http requests using an external library rather than avoiding adding it in the first place - to me, the cost of maintaining low level code is much higher than adding this single dependency.