fix: 'os.tmpDir is not a function' on recent Node versions #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
os
module breaking change whereos.tmpDir()
is nowos.tmpdir()
when running on macOS 10.15.1.req.files.image.ws.bytesWritten
is no longer available, so, a potential guess solution has been applied by usingreq.files.image.size
instead.Add photo
button on the photo-album sample:What Does This PR Address?
Are Tests Included?
Reviewer, Please Note:
Decision to replace
req.files.image.ws.bytesWritten
withreq.files.image.size
may not be correct as the former no longer appears to be available with an upgraded version of connect-multiparty, though I'm not certain this meets the original expectations of evaluating thebytesWritten
.