Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Restructure source code to make integration easier #180

Open
runlevel5 opened this issue Dec 2, 2015 · 1 comment
Open

Comments

@runlevel5
Copy link

Hi team

Firstly, thanks for a good service. We are using cloudinary gem at Envato and it has been smooth.

When I look into the source code of this gem, I find that there was a strong Rails integration (which is fine), however I think this gem can/should be used by other non-Rails framework too (or even pure Ruby). So I am wondering what do you think about splitting the non-Rails code into a core component and having a separate lib/cloudinary/rails.rb to include the core + rails integration. I believe this would allow other frameworks to develop integration with cloudinary without having to manually remove the rails integration part.

I am happy to provide PR if your team think it aligns with your product roadmap.

@taragano
Copy link
Collaborator

taragano commented Dec 4, 2015

Thank you very much for your suggestion. I've passed it on to our team to consider such an enhancement for future versions of our GEM.

@tocker tocker removed their assignment Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants