Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Update and Delete of Entities with Alias if Alias Feature is disabled #2803

Merged
merged 17 commits into from
Apr 9, 2024
Merged

Prevent Update and Delete of Entities with Alias if Alias Feature is disabled #2803

merged 17 commits into from
Apr 9, 2024

Commits on Mar 28, 2024

  1. Reject deletion of entities if alias exists and alias feature is disa… 

    …bled
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    07366c2 View commit details
    Browse the repository at this point in the history

  2. Adapt test to new behavior: Update -> AliasFeatureDisabled -> Existin… 

    …gAlias -> shouldAccept_ShouldIgnoreDanglingReference (renamed to "shouldReject_EvenIfAliasReferenceIsBroken")
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2b116b9 View commit details
    Browse the repository at this point in the history

  3. Adapt test to new behavior: Update -> AliasFeatureDisabled -> Existin… 

    …gAlias -> shouldAccept_SetAliasPropertiesToNullAndChangeOtherProperties (renamed to "shouldReject_SetAliasPropertiesToNullAndChangeOtherProperties")
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a7dbc53 View commit details
    Browse the repository at this point in the history

  4. Adapt test to new behavior: Update -> AliasFeatureDisabled -> Existin… 

    …gAlias -> shouldAccept_SetOnlyAliasPropertiesToNull (renamed to "shouldReject_SetOnlyAliasPropertiesToNull")
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cff69a3 View commit details
    Browse the repository at this point in the history

  5. Adapt test to new behavior: Update -> AliasFeatureDisabled -> Existin… 

    …gAlias -> shouldAccept_ShouldIgnoreAliasIdOfExistingIdpMissing (renamed to "shouldReject_AliasIdOfExistingIdpMissing")
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    195612e View commit details
    Browse the repository at this point in the history

  6. Remove unused method "assertReferenceWasRemovedFromAlias" from Identi… 

    …tyProviderEndpointsAliasMockMvcTests
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9acea9d View commit details
    Browse the repository at this point in the history

  7. Refactor assertion

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3ad9bc4 View commit details
    Browse the repository at this point in the history

  8. Adjust EntityAliasHandlerValidationTest to new update behavior

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2ba70ce View commit details
    Browse the repository at this point in the history

  9. Adjust validation logic in EntityAliasHandler to reject updates when … 

    …an alias exists but the alias feature is disabled
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0cc9ffb View commit details
    Browse the repository at this point in the history

  10. Remove reference break logic from EntityAliasHandler.ensureConsistenc… 

    …yOfAliasEntity
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5d00603 View commit details
    Browse the repository at this point in the history

  11. Adjust unit tests for ensureConsistency method

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    183d054 View commit details
    Browse the repository at this point in the history

  12. Change response status code of IdP delete to 422 if alias feature ena… 

    …bled and IdP has alias
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cfb506d View commit details
    Browse the repository at this point in the history

  13. Update endpoint docs

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ce599b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Fix unit test

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9b1ee68 View commit details
    Browse the repository at this point in the history

  2. Use only aliasZid field to check if an alias is present in IdP deleti… 

    …on endpoint
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e73ac2c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Add javadoc sections about IllegalStateExceptions being thrown in Ent… 

    …ityAliasHandler.ensureConsistencyOfAliasEntity
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ead4176 View commit details
    Browse the repository at this point in the history

  2. Merge documentation for 422 error codes of IdP endpoints

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    eca31fd View commit details
    Browse the repository at this point in the history