Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement service_instances and service_bindings endpoints #1139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanngiesser
Copy link
Contributor

@kanngiesser kanngiesser commented Nov 18, 2024

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

Outline

This PR adds the endpoints /v2/service_instances/:instance_id and /v2/service_instances/:instance_id/service_bindings/:binding_id which are defined by the Open Service Broker API Spec and updates the Service Catalog accordingly:

Service Catalog

  • sets the property "instances_retrievable": true for each service offering
  • sets the property "bindings_retrievable": true for each offering where "bindable" is true
    • (with the current implementation "bindable" is hard-coded to be true for all service offerings, though

/v2/service_instances/:instance_id

  • returns offeringID, PlanID and provision parameters
  • returns error codes according to OSB-API spec

/v2/service_instances/:instance_id/service_bindings/:binding_id

  • returns only binding parameters
  • returns error codes according to OSB-API spec

Copy link

linux-foundation-easycla bot commented Nov 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kanngiesser / name: Jonas Kanngießer (46dc69b)

@kanngiesser
Copy link
Contributor Author

The Markdown Link Check pipeline fails because https://github.com/cloudfoundry/cloud-service-broker/search?q=toggles.Features.Toggle&type=code returns status 429 (too many requests).

Please trigger a re-run of the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant