Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monit_utils: Add support for more than 10 cc workers #276

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ohkyle
Copy link

@ohkyle ohkyle commented Oct 10, 2022

Authored-by: Kyle Ong kyleo@vmware.com

Thanks for contributing to the capi_release. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ohkyle / name: Kyle Ong (52eb61d)

@ohkyle ohkyle force-pushed the support-many-cloud-controller-workers branch 2 times, most recently from b6c7507 to cb0838e Compare October 13, 2022 16:47
- cloudfoundry#267 identified a
  bug where the wait_unmonitor_job function assumed there would be less
  than 10 cloud controller workers
- this fix removes the less than 10 worker assumption and looks for the job_name in the
  regex

Authored-by: Kyle Ong <kyleo@vmware.com>
@ohkyle ohkyle force-pushed the support-many-cloud-controller-workers branch from cb0838e to 52eb61d Compare October 18, 2022 16:03
Copy link
Contributor

@MarcPaquette MarcPaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants