Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

use startupProbe instead of readinessProbe for rake-task based containers #110

Closed
wants to merge 1 commit into from

Conversation

tcdowney
Copy link
Member

@tcdowney tcdowney commented Nov 24, 2020

  • these jobs briefly listen on a socket while starting up, but do not maintain that socket long-term
  • these jobs run rake tasks that will crash when something goes wrong, so the regular liveness/readiness behavior of Kubernetes should suffice
  • this was "working" previously because the readiness check probe was connecting to the Istio sidecar instead of the rake task, we noticed issues once switching to a non-mesh ingress solution (like Contour)
  • removed the readinessProbe entirely from the registry-buddy since it does not accept external connections by design

Addresses #91
Tracker Story: #175388005

- these jobs briefly listen on a socket while starting up
but do not necessarily maintain that socket long-term
- these jobs run rake tasks that will crash when something goes wrong
so the regular liveness/readiness behavior of Kubernetes should suffice
- this was "working" previously because the readiness check probe was
connecting to the Istio sidecar instead of the rake task, we noticed
issues once switching to a non-mesh ingress solution (like Contour)
- addresses #91

Authored-by: Tim Downey <tdowney@vmware.com>

[#175388005](https://www.pivotaltracker.com/story/show/175388005)
@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@tcdowney tcdowney changed the title use startupProbe instead of readinessProbe for rake-task based jobs use startupProbe instead of readinessProbe for rake-task based containers Nov 24, 2020
@tcdowney
Copy link
Member Author

Closing this for now. I'm not sure the startupProbes are working correctly on my k8s 1.18 env. They seem to be falsely succeeding...
kubernetes/kubernetes#92196

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants