Skip to content

fix: Correct public IP prefixes reference in NATGatewaysManager and r… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

long-pham-ts
Copy link

@long-pham-ts long-pham-ts commented Jun 9, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Correct public_ip_prefixes reference in NATGatewaysManage
  • Remove autoscale_settings from VMScaleSetsManager

Known issue

Copy link

github-actions bot commented Jun 9, 2025

⚠️ @long-pham-ts the signed-off-by was not found in the following 1 commits:

  • 1fffd2a: fix: Correct public IP prefixes reference in NATGatewaysManager and remove autoscale_settings from VMScaleSetsManager

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

github-actions bot commented Jun 9, 2025

⚠️ @long-pham-ts the signed-off-by was not found in the following 1 commits:

  • 1fffd2a: fix: Correct public IP prefixes reference in NATGatewaysManager and remove autoscale_settings from VMScaleSetsManager

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

github-actions bot commented Jun 9, 2025

⚠️ @long-pham-ts the signed-off-by was not found in the following 2 commits:

  • 1fffd2a: fix: Correct public IP prefixes reference in NATGatewaysManager and remove autoscale_settings from VMScaleSetsManager
  • 8bd21b1: Merge remote-tracking branch 'origin/fix/scaleset_natgateway' into fix/scaleset_natgateway

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
Copy link

github-actions bot commented Jun 9, 2025

⚠️ @long-pham-ts the signed-off-by was not found in the following 2 commits:

  • 1fffd2a: fix: Correct public IP prefixes reference in NATGatewaysManager and remove autoscale_settings from VMScaleSetsManager
  • 8bd21b1: Merge remote-tracking branch 'origin/fix/scaleset_natgateway' into fix/scaleset_natgateway

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

…emove autoscale_settings from VMScaleSetsManager

Signed-off-by: long-pham-ts <long.pham@trustingsocial.com>
Signed-off-by: long-pham-ts <long.pham@trustingsocial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant