Remove special handling for 'Failed to start ProxyWorker or InspectorProxyWorker'

[penalosa]

Fixes #6510, fixes #4637

Remove the special handling for the Failed to start ProxyWorker or InspectorProxyWorker error. The intention of this code was to recover from port conflicts when running wrangler dev, but it actually seems to have been causing orphaned workerd processes. Because we use getPort() when resolving config in ConfigController, the only way this code path is hit is if the proxy workerd instance fails to start because of a port conflict where the user has specified a port (i.e. with --port or dev.port = ) that conflicts (or is reserved e.g. 80). In those cases, this codepath restarted workerd with a different port, but also ended up hitting throw error; in ProxyController, which ended up with a global uncaught exception that crashed the Wrangler process, leaving dangling workerd processes. This meant that the recovery logic wasn't working.

This PR removes the recovery logic entirely, which allows the general DevEnv error handling to take over. This means that workerd should be cleaned up properly, and the user-facing error messages should be nicer.

Previous address-in-use error:

New address-in-use error:

---

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix

[changeset-bot]

🦋 Changeset detected

Latest commit: f961143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-wrangler-7169

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7169/npm-package-wrangler-7169

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-wrangler-7169 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-create-cloudflare-7169 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-kv-asset-handler-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-miniflare-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-pages-shared-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-vitest-pool-workers-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-workers-editor-shared-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-workers-shared-7169

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11724419612/npm-package-cloudflare-workflows-shared-7169

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.85.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241022.0
workerd	1.20241106.1	1.20241106.1
workerd --version	1.20241106.1	2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.