Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update devtools patches #6959

Closed
wants to merge 9 commits into from
Closed

chore: update devtools patches #6959

wants to merge 9 commits into from

Conversation

andyjessop
Copy link
Contributor

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7841745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-wrangler-6959

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6959/npm-package-wrangler-6959

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-wrangler-6959 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-create-cloudflare-6959 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-cloudflare-kv-asset-handler-6959
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-miniflare-6959
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-cloudflare-pages-shared-6959
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-cloudflare-vitest-pool-workers-6959
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-cloudflare-workers-editor-shared-6959
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384008687/npm-package-cloudflare-workers-shared-6959

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.80.5 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the preview:chrome-devtools-patches Trigger a devtools preview deploy label Oct 14, 2024
penalosa
penalosa reviewed Oct 14, 2024
View reviewed changes
packages/wrangler-devtools/.gclient Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to the gitignore

packages/wrangler-devtools/.gclient_entries Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

packages/wrangler-devtools/.gclient_previous_sync_commits Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

packages/wrangler-devtools/.gcs_entries Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

packages/wrangler-devtools/Makefile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

packages/wrangler-devtools/patches/0001-Support-viewing-files-over-the-network.patch
@@ -74,16 +74,16 @@ index a0c126df12..4b8244ea69 100644
persistence: UI.ViewManager.ViewPersistence.PERMANENT,
async loadView() {
const Sources = await loadSourcesModule();
- return Sources.SourcesNavigator.FilesNavigatorView.instance();
- return new Sources.SourcesNavigator.FilesNavigatorView();
+ return Sources.SourcesNavigator.NetworkNavigatorView.instance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a new?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good spot 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, apparently not. It uses the static method to instantiate.

packages/wrangler-devtools/patches/0003-Support-previewing-subrequest-responses.patch
return;
}
this.getExtraInfoBuilder(requestId).finished();
+ if (cfResponse !== undefined) {
+ networkRequest.setContentDataProvider(async () => {
+ return { error: null, content: cfResponse.body, encoded: cfResponse.base64Encoded };
+ return { error: '', content: cfResponse.body, encoded: cfResponse.base64Encoded };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new type constraint in the frontend-devtools application.

@penalosa
Copy link
Contributor

penalosa commented Nov 5, 2024

Closing in favour of #7137

@penalosa penalosa closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa left review comments

Assignees
No one assigned
Labels
preview:chrome-devtools-patches Trigger a devtools preview deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyjessop @penalosa