Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Aug 22, 2025

The changes in this PR allow durable objects to have enableSql, unsafeUniqueKey and unsafePreventEviction configurations set to undefined even if they same durable objects are defined with those configurations set to a different value (this would allow workers using external durable objects not to have to duplicate such configurations in their options)


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: b05ea08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 22, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10437

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10437

miniflare

npm i https://pkg.pr.new/miniflare@10437

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10437

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10437

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10437

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10437

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10437

wrangler

npm i https://pkg.pr.new/wrangler@10437

commit: b05ea08

@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-mf-enablesql-checks branch 2 times, most recently from 589b33c to 35a9eb2 Compare August 22, 2025 20:42
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review August 22, 2025 20:43
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner August 22, 2025 20:43
@dario-piotrowicz dario-piotrowicz changed the title fix different storage backends DO issue Loosen validation around different configurations for Durable Object Aug 22, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-mf-enablesql-checks branch 2 times, most recently from b6dfab9 to 1ff53ba Compare August 26, 2025 10:44
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 26, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-mf-enablesql-checks branch from 062e840 to 72f604b Compare August 27, 2025 12:34
@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-mf-enablesql-checks branch from 72f604b to fedf7a4 Compare August 27, 2025 16:24
@jamesopstad jamesopstad merged commit 452ad0b into main Aug 27, 2025
47 of 50 checks passed
@jamesopstad jamesopstad deleted the dario/fix-mf-enablesql-checks branch August 27, 2025 19:03
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants