Skip to content

Commit f6f4f78

Browse files
devin-ai-integration[bot]penalosa
authored andcommitted
Address PR feedback: add comment and use Analytics Engine test
Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>
1 parent bfd0997 commit f6f4f78

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -272,28 +272,25 @@ describe("ConfigController", () => {
272272
const std = mockConsoleMethods();
273273

274274
await seed({
275-
"src/index.ts": dedent/* javascript */ `
276-
export default {
277-
fetch(request, env, ctx) {
278-
return new Response("hello world")
279-
}
280-
} satisfies ExportedHandler
275+
"src/index.js": dedent/* javascript */ `
276+
addEventListener('fetch', event => {
277+
event.respondWith(new Response('hello world'))
278+
})
281279
`,
282280
"wrangler.toml": dedent/* toml */ `
283281
name = "my-worker"
284-
main = "src/index.ts"
282+
main = "src/index.js"
285283
compatibility_date = "2024-06-01"
286284
287-
[[queues.consumers]]
288-
queue = "my-queue"
289-
max_batch_size = 10
285+
[[analytics_engine_datasets]]
286+
binding = "ANALYTICS"
287+
dataset = "analytics_dataset"
290288
`,
291289
});
292290

293291
const event1 = waitForConfigUpdate(controller);
294292
await controller.set({
295293
config: "./wrangler.toml",
296-
dev: { remote: true },
297294
});
298295
await event1;
299296

@@ -313,7 +310,7 @@ describe("ConfigController", () => {
313310
.split("\n")
314311
.filter((line) =>
315312
line.includes(
316-
"Queues are not yet supported in wrangler dev remote mode"
313+
"Analytics Engine is not supported locally when using the service-worker format"
317314
)
318315
).length;
319316

packages/wrangler/src/__tests__/dev.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2112,6 +2112,10 @@ describe.sequential("wrangler dev", () => {
21122112

21132113
describe("containers", () => {
21142114
beforeEach(() => {
2115+
// Clear logger.once history between tests to ensure test isolation.
2116+
// Without this, warnings logged via logger.once.warn() in one test
2117+
// would be suppressed in subsequent tests since they track logged
2118+
// messages globally across the test process.
21152119
logger.clearHistory();
21162120
});
21172121

0 commit comments

Comments
 (0)