Skip to content

Commit e498685

Browse files
Address PR feedback: add comment and use Analytics Engine test
Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>
1 parent d8c25c4 commit e498685

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -244,28 +244,25 @@ describe("ConfigController", () => {
244244
const std = mockConsoleMethods();
245245

246246
await seed({
247-
"src/index.ts": dedent/* javascript */ `
248-
export default {
249-
fetch(request, env, ctx) {
250-
return new Response("hello world")
251-
}
252-
} satisfies ExportedHandler
247+
"src/index.js": dedent/* javascript */ `
248+
addEventListener('fetch', event => {
249+
event.respondWith(new Response('hello world'))
250+
})
253251
`,
254252
"wrangler.toml": dedent/* toml */ `
255253
name = "my-worker"
256-
main = "src/index.ts"
254+
main = "src/index.js"
257255
compatibility_date = "2024-06-01"
258256
259-
[[queues.consumers]]
260-
queue = "my-queue"
261-
max_batch_size = 10
257+
[[analytics_engine_datasets]]
258+
binding = "ANALYTICS"
259+
dataset = "analytics_dataset"
262260
`,
263261
});
264262

265263
const event1 = waitForConfigUpdate(controller);
266264
await controller.set({
267265
config: "./wrangler.toml",
268-
dev: { remote: true },
269266
});
270267
await event1;
271268

@@ -285,7 +282,7 @@ describe("ConfigController", () => {
285282
.split("\n")
286283
.filter((line) =>
287284
line.includes(
288-
"Queues are not yet supported in wrangler dev remote mode"
285+
"Analytics Engine is not supported locally when using the service-worker format"
289286
)
290287
).length;
291288

packages/wrangler/src/__tests__/dev.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2112,6 +2112,10 @@ describe.sequential("wrangler dev", () => {
21122112

21132113
describe("containers", () => {
21142114
beforeEach(() => {
2115+
// Clear logger.once history between tests to ensure test isolation.
2116+
// Without this, warnings logged via logger.once.warn() in one test
2117+
// would be suppressed in subsequent tests since they track logged
2118+
// messages globally across the test process.
21152119
logger.clearHistory();
21162120
});
21172121

0 commit comments

Comments
 (0)