Commit dbe51c1
[wrangler] Fix self-bindings showing as not connected in dev (#10915)
* fix: self-bindings show as connected in wrangler dev
Fixes #8970
Self-bindings (service bindings where a worker binds to itself) were
incorrectly showing as [not connected] in wrangler dev. This change
detects self-bindings by comparing the service name to the worker name
and always marks them as connected, since a worker is inherently
connected to itself.
- Modified print-bindings.ts to check for self-bindings before registry lookup
- Added test for self-bindings showing as [connected]
- Manually verified with workers-with-assets fixture
Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>
* fix: correct test snapshot for self-bindings table formatting
The table column widths are dynamically calculated based on content
length. The self-bindings test has longer binding names than other
service binding tests, which causes wider column spacing in the output.
Updated the snapshot to match the actual table formatting.
Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: smacleod@cloudflare.com <smacleod@cloudflare.com>1 parent d4f2daf commit dbe51c1
File tree
3 files changed
+49
-9
lines changed- .changeset
- packages/wrangler/src
- __tests__
- utils
3 files changed
+49
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2025 | 2025 | | |
2026 | 2026 | | |
2027 | 2027 | | |
| 2028 | + | |
| 2029 | + | |
| 2030 | + | |
| 2031 | + | |
| 2032 | + | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
| 2037 | + | |
| 2038 | + | |
| 2039 | + | |
| 2040 | + | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
| 2049 | + | |
| 2050 | + | |
| 2051 | + | |
| 2052 | + | |
| 2053 | + | |
| 2054 | + | |
| 2055 | + | |
2028 | 2056 | | |
2029 | 2057 | | |
2030 | 2058 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
391 | 391 | | |
392 | 392 | | |
393 | 393 | | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
402 | 398 | | |
403 | 399 | | |
404 | | - | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
405 | 412 | | |
406 | 413 | | |
407 | 414 | | |
| |||
0 commit comments