fix: prevent duplicate warning messages in wrangler dev (v3 backport) (#10962)

* fix: prevent duplicate warning messages in wrangler dev (v3 backport)

Changes all logger.warn() calls to logger.once.warn() in ConfigController.ts
to ensure warnings are only shown once even when configuration is updated
multiple times.

Also adds a test to verify warnings are only logged once across multiple
config updates.

Backport of #10913 to v3-maintenance branch.

Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>

* Add changeset for v3 backport

Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: smacleod@cloudflare.com <smacleod@cloudflare.com>

Author: devin-ai-integration[bot]

.changeset/tasty-moose-matter.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fixed duplicate warning messages appearing during wrangler dev when configuration changes or state transitions occur

packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts

@@ -223,4 +223,62 @@ base_dir = \"./some/base_dir\"`,
 			apiToken: { apiToken: "some-api-token" },
 		});
 	});
+
+	it("should only log warnings once even with multiple config updates", async () => {
+		const std = mockConsoleMethods();
+		const controller = new ConfigController();
+
+		await seed({
+			"src/index.ts": dedent/* javascript */ `
+				export default class MyDurableObject {
+					constructor(state, env) {}
+					async fetch(request) {
+						return new Response("Hello");
+					}
+				}
+			`,
+			"wrangler.toml": dedent/* toml */ `
+				name = "my-worker"
+				main = "src/index.ts"
+				compatibility_date = "2024-06-01"
+
+				[[durable_objects.bindings]]
+				name = "MY_DO"
+				class_name = "MyDurableObject"
+
+				[[migrations]]
+				tag = "v1"
+				new_sqlite_classes = ["MyDurableObject"]
+			`,
+		});
+
+		const event1 = waitForConfigUpdate(controller);
+		await controller.set({
+			config: "./wrangler.toml",
+			dev: { remote: true },
+		});
+		await event1;
+
+		const event2 = waitForConfigUpdate(controller);
+		await controller.patch({
+			dev: { liveReload: true },
+		});
+		await event2;
+
+		const event3 = waitForConfigUpdate(controller);
+		await controller.patch({
+			dev: { server: { port: 8787 } },
+		});
+		await event3;
+
+		const warningCount = std.warn
+			.split("\n")
+			.filter((line) =>
+				line.includes(
+					"SQLite in Durable Objects is only supported in local mode"
+				)
+			).length;
+
+		expect(warningCount).toBe(1);
+	});
 });

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -338,7 +338,7 @@ async function resolveConfig(
 
 	const services = extractBindingsOfType("service", resolved.bindings);
 	if (services && services.length > 0 && resolved.dev?.remote) {
-		logger.warn(
+		logger.once.warn(
 			`This worker is bound to live services: ${services
 				.map(
 					(service) =>
@@ -351,7 +351,7 @@ async function resolveConfig(
 	}
 
 	if (!resolved.dev?.origin?.secure && resolved.dev?.remote) {
-		logger.warn(
+		logger.once.warn(
 			"Setting upstream-protocol to http is not currently supported for remote mode.\n" +
 				"If this is required in your project, please add your use case to the following issue:\n" +
 				"https://github.com/cloudflare/workers-sdk/issues/583."
@@ -365,7 +365,9 @@ async function resolveConfig(
 		(queues?.length ||
 			resolved.triggers?.some((t) => t.type === "queue-consumer"))
 	) {
-		logger.warn("Queues are not yet supported in wrangler dev remote mode.");
+		logger.once.warn(
+			"Queues are not yet supported in wrangler dev remote mode."
+		);
 	}
 
 	// TODO(do) support remote wrangler dev
@@ -376,7 +378,9 @@ async function resolveConfig(
 		resolved.dev.remote &&
 		Array.from(classNamesWhichUseSQLite.values()).some((v) => v)
 	) {
-		logger.warn("SQLite in Durable Objects is only supported in local mode.");
+		logger.once.warn(
+			"SQLite in Durable Objects is only supported in local mode."
+		);
 	}
 
 	return resolved;