EW-9466 EW-9596 Add perf event marking to performance.now() #5097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
approved these changes
Sep 16, 2025
mschwarzl
approved these changes
Sep 16, 2025
|
There is a conflict due to the revert of performance changes. The new PR that reverts the revert of revert is #5103 |
|
I'll wait for the dust to settle. :) |
Appreciate it! |
harrishancock
force-pushed
the
harris/EW-9466-perf-event-mark
branch
from
a73ab30 to
7efe07f
Compare
harrishancock
changed the base branch from
main
to
yagiz/revert-revert-revert-performance
harrishancock
force-pushed
the
harris/EW-9466-perf-event-mark
branch
from
7efe07f to
8e86810
Compare
|
Once the revert is all settled out, you might consider also adding support for this in the |
anonrig
force-pushed
the
yagiz/revert-revert-revert-performance
branch
7 times, most recently
from
88b8391 to
c1aff5f
Compare
Base automatically changed from
yagiz/revert-revert-revert-performance
to
main
September 18, 2025 19:40
|
Hi @harrishancock, can you rebase? |
harrishancock
force-pushed
the
harris/EW-9466-perf-event-mark
branch
from
8e86810 to
6bd308d
Compare
|
Done. I added instrumentation to I suppose it would make sense to move those two events to the PerformanceMark and PerformanceMeasure class constructors, but I didn't want to think too hard about the change right now. |
jasnell
reviewed
Sep 19, 2025
jasnell
reviewed
Sep 19, 2025
jasnell
approved these changes
Sep 19, 2025
anonrig
reviewed
Sep 23, 2025
harrishancock
force-pushed
the
harris/EW-9466-perf-event-mark
branch
3 times, most recently
from
c024360 to
0ff0dae
Compare
This commit contains two changes: - Adds an IsolateLimitEnforcer::markPerfEvent(name) function whose default implementation is a no-op. Its internal implementation injects perf counter data into our perf_event observability system. - Calls the function from performance.now(). This allows us to see what our perf_event counters are at the moment in time when JS calls that API.
I added perf event marks to Performance.mark() and Performance.measure(). It'd probably make a lot of sense to pass the mark name as the perf event's name, but our system currently requires the names to be static strings, so I just left them as "performance_now" and "performance_measure". Note that I changed calls to now(js) to the underlying implementation, dateNow(), to avoid spuriously injecting extra "performance_now" events.
harrishancock
force-pushed
the
harris/EW-9466-perf-event-mark
branch
from
0ff0dae to
e150a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains two changes: