refactor(bazel): move v8 and perfetto to bzlmod

Author: alexeagle

MODULE.bazel

@@ -5,14 +5,6 @@ bazel_dep(name = "bazel_features", version = "1.35.0")
 bazel_dep(name = "bazel_skylib", version = "1.8.1")
 bazel_dep(name = "rules_shell", version = "0.6.0")
 
-# needed by perfetto, but not actually used.
-bazel_dep(name = "rules_android", version = "0.6.4")
-
-# protobuf for use with perfetto
-# Updated protobuf can't be imported reliably under WORKSPACE logic in Bazel 8, so we need to use
-# bzlmod.
-bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
-
 # abseil is used by protobuf and tcmalloc.
 bazel_dep(name = "abseil-cpp", version = "20250814.0")
 
@@ -44,7 +36,6 @@ git_override(
 bazel_dep(name = "boringssl", version = "0.20250818.0", repo_name = "ssl")
 
 include("//build/deps:deps.MODULE.bazel")
-
 include("//build/deps:nodejs.MODULE.bazel")
-
 include("//build/deps:python.MODULE.bazel")
+include("//build/deps:v8.MODULE.bazel")

WORKSPACE

@@ -19,10 +19,6 @@ load("//:build/rust_toolchains.bzl", "rust_toolchains")
 
 rust_toolchains()
 
-load("@//build/deps:v8.bzl", "deps_v8")
-
-deps_v8()
-
 bind(
     name = "icu",
     actual = "@com_googlesource_chromium_icu//:icu",

build/deps/v8.MODULE.bazel

@@ -0,0 +1,87 @@
+"""
+V8 and its dependencies
+
+Note that googlesource does not generate tarballs deterministically, so we cannot use
+http_archive: https://github.com/google/gitiles/issues/84
+
+It would seem that googlesource would rather we use git protocol.
+Fine, we can do that.
+
+We previously used shallow_since for our git-based dependencies, but this may actually be
+harmful: https://github.com/bazelbuild/bazel/issues/12857
+
+There is an official mirror for V8 itself on GitHub, but not for dependencies like zlib (Chromium
+fork), icu (Chromium fork), and trace_event, so we still have to use git for them.
+"""
+bazel_dep(name = "perfetto", version = "0.0.0")
+
+http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+git_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
+
+VERSION = "14.1.146.1"
+
+INTEGRITY = "sha256-2HdTM2N2J1XBI6617Icx73S2qs5+Qd/h4hQUek8CUFU="
+
+PATCHES = [
+    "0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
+    "0002-Allow-manually-setting-ValueSerializer-format-versio.patch",
+    "0003-Allow-Windows-builds-under-Bazel.patch",
+    "0004-Disable-bazel-whole-archive-build.patch",
+    "0005-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch",
+    "0006-Implement-Promise-Context-Tagging.patch",
+    "0007-Randomize-the-initial-ExecutionContextId-used-by-the.patch",
+    "0008-increase-visibility-of-virtual-method.patch",
+    "0009-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
+    "0010-Modify-where-to-look-for-fp16-dependency.-This-depen.patch",
+    "0011-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
+    "0012-Update-illegal-invocation-error-message-in-v8.patch",
+    "0013-Implement-cross-request-context-promise-resolve-hand.patch",
+    "0014-Add-another-slot-in-the-isolate-for-embedder.patch",
+    "0015-Add-ValueSerializer-SetTreatProxiesAsHostObjects.patch",
+    "0016-Disable-memory-leak-assert-when-shutting-down-V8.patch",
+    "0017-Enable-V8-shared-linkage.patch",
+    "0018-Modify-where-to-look-for-fast_float-and-simdutf.patch",
+    "0019-Remove-unneded-latomic-linker-flag.patch",
+    "0020-Add-methods-to-get-heap-and-external-memory-sizes-di.patch",
+    "0021-Remove-DCHECK-from-WriteOneByteV2-to-skip-v8-fatal.patch",
+    "0022-Port-concurrent-mksnapshot-support.patch",
+    "0023-Port-V8_USE_ZLIB-support.patch",
+    "0024-Modify-where-to-look-for-dragonbox.patch",
+    "0025-Disable-slow-handle-check.patch",
+    "0026-Workaround-for-builtin-can-allocate-issue.patch",
+    "0027-Implement-additional-Exception-construction-methods.patch",
+    "0028-Export-icudata-file-to-facilitate-embedding-it.patch",
+    "0029-IsGraphAsync-module-cast-check.patch",
+]
+
+http_archive(
+    name = "v8",
+    integrity = INTEGRITY,
+    patch_args = ["-p1"],
+    patches = ["//:patches/v8/" + p for p in PATCHES],
+    strip_prefix = "v8-" + VERSION,
+    url = "https://github.com/v8/v8/archive/refs/tags/" + VERSION + ".tar.gz",
+)
+
+git_repository(
+    name = "com_googlesource_chromium_icu",
+    build_file = "@v8//:bazel/BUILD.icu",
+    commit = "1b2e3e8a421efae36141a7b932b41e315b089af8",
+    patch_cmds = ["find source -name BUILD.bazel | xargs rm"],
+    patch_cmds_win = ["Get-ChildItem -Path source -File -Include BUILD.bazel -Recurse | Remove-Item"],
+    remote = "https://chromium.googlesource.com/chromium/deps/icu.git",
+)
+
+archive_override(
+    module_name = "perfetto",
+    patches = ["//:patches/perfetto/MODULE.bazel.patch"],
+    integrity = "sha256-T5F4h9xXdYfTGMa+AXmewHIkS1cgxu5ierfyJMOwqJA=",
+    strip_prefix = "perfetto-51.2",
+    url = "https://github.com/google/perfetto/archive/refs/tags/v51.2.tar.gz",
+)
+
+# For use with perfetto, see https://github.com/google/perfetto/blob/main/bazel/standalone/README.md
+local_path_override(
+    module_name = "perfetto_cfg",
+    path = "build/perfetto",
+)

build/deps/v8.bzl

@@ -0,0 +1,2 @@
+
+module(name = "perfetto_cfg")

build/perfetto/BUILD

@@ -60,6 +60,7 @@ PERFETTO_CONFIG = struct(
         protobuf_py = [],
         pandas_py = [],
         tp_vendor_py = [],
+        tp_resolvers_py = [],
 
         # There are multiple configurations for the function name demangling
         # logic in trace processor:

build/perfetto/MODULE.bazel

@@ -18,7 +18,7 @@ To update the version of V8 used by workerd, the steps are:
 
 4. Sync the local copy of V8 to the version used by workerd.
 
-   First, find workerd's current version of V8 in `v8.bzl`. We will call this `<old_version>`.
+   First, find workerd's current version of V8 in `v8.MODULE.bazel`. We will call this `<old_version>`.
 
    Then sync your fetched version v8 based on the tag.
 
@@ -56,7 +56,7 @@ To update the version of V8 used by workerd, the steps are:
 8. Remove the existing patches from `<path_to_workerd>/patches/v8` and copy over the latest generated patches
 from the V8 directory.
 
-9. Update the `VERSION` for V8 in `v8.bzl`.
+9. Update the `VERSION` for V8 in `v8.MODULE.bazel`.
 
     The list of patches should be refreshed if new patches are being added or existing
     patches are being removed.
@@ -66,13 +66,13 @@ from the V8 directory.
     workerd using the newer V8 version or by running
     `openssl dgst -sha256 -binary <tarball_filename> | openssl base64 -A`
 
-10. Update V8's dependencies in `v8.bzl` and `WORKSPACE`.
+10. Update V8's dependencies in `v8.MODULE.bazel` and `WORKSPACE`.
 
     You can find the commit versions for V8's dependencies under `<path_to_v8>/DEPS`.
 
     These currently include `zlib` and `com_googlesource_chromium_icu`.
     Typically you'll get a build failure if the projects are out of sync. Copy the
-    commit versions from `v8/DEPS` to the `v8.bzl` or `WORKSPACE` file.
+    commit versions from `v8/DEPS` to the `v8.MODULE.bazel` or `WORKSPACE` file.
 
 11. Check workerd's tests pass with the updated V8.
 

build/perfetto/perfetto_cfg.bzl

@@ -0,0 +1,12 @@
+--- MODULE.bazel
++++ MODULE.bazel
+@@ -11,5 +11,9 @@
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
++module(name = "perfetto")
++bazel_dep(name = "perfetto_cfg", version = "0.0.0")
++bazel_dep(name = "platforms", version = "1.0.0")
++bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
+
+ bazel_dep(name = "rules_android", version = "0.6.0")