Skip to content

Commit 7af77af

Browse files
authored
Merge pull request #1205 from suhrit-cf/master
Add ExcludeOfficeIPs flag for policy
2 parents 2f11f72 + dc84128 commit 7af77af

File tree

3 files changed

+39
-30
lines changed

3 files changed

+39
-30
lines changed

.changelog/1205.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
devices_policy: Add new exclude_office_ips field to policy
3+
```

devices_policy.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ type DeviceSettingsPolicy struct {
4242
Match *string `json:"match"`
4343
Precedence *int `json:"precedence"`
4444
Default bool `json:"default"`
45+
ExcludeOfficeIps *bool `json:"exclude_office_ips"`
4546
}
4647

4748
type DeviceSettingsPolicyResponse struct {
@@ -68,6 +69,7 @@ type DeviceSettingsPolicyRequest struct {
6869
Name *string `json:"name,omitempty"`
6970
Match *string `json:"match,omitempty"`
7071
Enabled *bool `json:"enabled,omitempty"`
72+
ExcludeOfficeIps *bool `json:"exclude_office_ips"`
7173
}
7274

7375
// UpdateDeviceClientCertificates controls the zero trust zone used to provision client certificates.

devices_policy_test.go

Lines changed: 34 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,21 @@ var (
2727
{Address: "10.0.0.0/8"},
2828
{Address: "100.64.0.0/10"},
2929
},
30-
GatewayUniqueID: StringPtr("t1235"),
31-
SupportURL: StringPtr(""),
32-
CaptivePortal: IntPtr(180),
33-
AllowModeSwitch: BoolPtr(false),
34-
SwitchLocked: BoolPtr(false),
35-
AllowUpdates: BoolPtr(false),
36-
AutoConnect: IntPtr(0),
37-
AllowedToLeave: BoolPtr(true),
38-
Enabled: BoolPtr(true),
39-
PolicyID: nil,
40-
Name: nil,
41-
Match: nil,
42-
Precedence: nil,
43-
Default: true,
30+
GatewayUniqueID: StringPtr("t1235"),
31+
SupportURL: StringPtr(""),
32+
CaptivePortal: IntPtr(180),
33+
AllowModeSwitch: BoolPtr(false),
34+
SwitchLocked: BoolPtr(false),
35+
AllowUpdates: BoolPtr(false),
36+
AutoConnect: IntPtr(0),
37+
AllowedToLeave: BoolPtr(true),
38+
Enabled: BoolPtr(true),
39+
PolicyID: nil,
40+
Name: nil,
41+
Match: nil,
42+
Precedence: nil,
43+
Default: true,
44+
ExcludeOfficeIps: BoolPtr(false),
4445
}
4546

4647
nonDefaultDeviceSettingsPolicy = DeviceSettingsPolicy{
@@ -56,20 +57,21 @@ var (
5657
{Address: "10.0.0.0/8"},
5758
{Address: "100.64.0.0/10"},
5859
},
59-
GatewayUniqueID: StringPtr("t1235"),
60-
SupportURL: StringPtr(""),
61-
CaptivePortal: IntPtr(180),
62-
AllowModeSwitch: BoolPtr(false),
63-
SwitchLocked: BoolPtr(false),
64-
AllowUpdates: BoolPtr(false),
65-
AutoConnect: IntPtr(0),
66-
AllowedToLeave: BoolPtr(true),
67-
PolicyID: &deviceSettingsPolicyID,
68-
Enabled: BoolPtr(true),
69-
Name: StringPtr("test"),
70-
Match: &deviceSettingsPolicyMatch,
71-
Precedence: &deviceSettingsPolicyPrecedence,
72-
Default: false,
60+
GatewayUniqueID: StringPtr("t1235"),
61+
SupportURL: StringPtr(""),
62+
CaptivePortal: IntPtr(180),
63+
AllowModeSwitch: BoolPtr(false),
64+
SwitchLocked: BoolPtr(false),
65+
AllowUpdates: BoolPtr(false),
66+
AutoConnect: IntPtr(0),
67+
AllowedToLeave: BoolPtr(true),
68+
PolicyID: &deviceSettingsPolicyID,
69+
Enabled: BoolPtr(true),
70+
Name: StringPtr("test"),
71+
Match: &deviceSettingsPolicyMatch,
72+
Precedence: &deviceSettingsPolicyPrecedence,
73+
Default: false,
74+
ExcludeOfficeIps: BoolPtr(true),
7375
}
7476

7577
defaultDeviceSettingsPolicyJson = `{
@@ -102,7 +104,8 @@ var (
102104
"auto_connect": 0,
103105
"allowed_to_leave": true,
104106
"enabled": true,
105-
"default": true
107+
"default": true,
108+
"exclude_office_ips":false
106109
}`
107110

108111
nonDefaultDeviceSettingsPolicyJson = fmt.Sprintf(`{
@@ -139,7 +142,8 @@ var (
139142
"name": "test",
140143
"match": %#v,
141144
"precedence": 10,
142-
"default": false
145+
"default": false,
146+
"exclude_office_ips":true
143147
}`, deviceSettingsPolicyID, deviceSettingsPolicyMatch)
144148
)
145149

0 commit comments

Comments
 (0)