Improve sequence extension documentation #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
added a commit
to yordis/spec
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> fixes cloudevents#1366
yordis
force-pushed
the
yordis/fixes-1364
branch
from
f9930bd to
c90c905
Compare
Collaborator
|
/cc @deissnerk |
yordis
added a commit
to yordis/spec
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> fixes cloudevents#1366
yordis
force-pushed
the
yordis/fixes-1364
branch
from
c90c905 to
cc57161
Compare
Collaborator
|
Minor thing, but can you make the events in your example full CEs? Meaning add the missing required attributes? |
duglin
reviewed
Aug 28, 2025
yordis
added a commit
to yordis/spec
that referenced
this pull request
Aug 28, 2025
fixes cloudevents#1366 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-1364
branch
from
cc57161 to
20d919e
Compare
yordis
added a commit
to yordis/spec
that referenced
this pull request
Aug 28, 2025
fixes cloudevents#1366 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-1364
branch
from
20d919e to
a1a3b79
Compare
duglin
reviewed
Sep 2, 2025
yordis
added a commit
to yordis/spec
that referenced
this pull request
Sep 2, 2025
fixes cloudevents#1366 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-1364
branch
from
a1a3b79 to
01f50aa
Compare
Collaborator
|
LGTM |
Contributor
|
LGTM |
fixes cloudevents#1366 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-1364
branch
from
01f50aa to
c89e133
Compare
Collaborator
|
Approved on the Sep 4 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1364