Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create abstract cloudevent #186
refactor: create abstract cloudevent #186
Changes from all commits
9422e62
6c6508b
494170b
202c987
8f98d65
781d914
fe3a2d0
188e7b7
39c838a
5c0af53
f55d247
aaa8098
207c4a8
41a9af2
5f8399f
2b64830
4488201
f1ff009
c747f59
6588577
01041e7
5648968
09062e3
a96bd6c
3845aa7
fb4f993
1187600
ecf9418
b9e8763
62595ff
2b3c0f1
a22efbd
89d30eb
d303eae
ba16cdd
ea19f7d
f47087d
41c5f59
5d0882d
6a92016
1109bc5
c0b5413
065ef91
a8872b9
fbc0632
0c2bafc
4e00b55
96c41a1
d129e6a
48de8e1
26e551b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we mark this method as abstract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it causes issues in the code coverage tests.
I cannot trigger the line to be called because an abstract method call fails before the function is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure, but that's not a valid reason to make smth not abstract. You can just create a test no-op or error-throwing implementation directly in the test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried testing the code directly but it did not actually executed the
pass
line of the functionbecause the abstract method raised an exception before reaching the pass.
I will do the thing that is mentioned here
https://stackoverflow.com/questions/9202723/excluding-abstractproperties-from-coverage-reports