Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated pypi package #73

Closed
cumason123 opened this issue Jul 27, 2020 · 6 comments
Closed

Outdated pypi package #73

cumason123 opened this issue Jul 27, 2020 · 6 comments
Assignees

Comments

@cumason123
Copy link
Contributor

Expected Behavior

Following code should work using the pypi package.

pip install cloudevents
python
>>> from cloudevents.sdk.http import CloudEvent

Actual Behavior

pip install cloudevents
python
>>> from cloudevents.sdk.http import CloudEvent

Throws error because module http does not exist due to pypi being outdated.

Ultimately i'm asking if everyone thinks branch v1.0.0-dev should be considered stable now, and if not what else can be done.

@cumason123
Copy link
Contributor Author

@evankanderson @di I would like to publish v1.0.0-dev this week if possible. Any feedback on additional issues we should resolve before publishing would be appreciated!

@di
Copy link
Member

di commented Jul 27, 2020

@cumason123 Should we consider publishing a pre-release on PyPI first, to allow consumers to test before publishing 1.0.0?

@grant
Copy link
Member

grant commented Jul 27, 2020

Sounds good. Things seem pretty stable and Curtis has added a lot of improvements with PRs.
I think we can go with a normal release unless there's a good reason for a prerelease? Not sure which consumers we'd expect to get feedback from within some timeframe.

@grant
Copy link
Member

grant commented Jul 29, 2020

@evankanderson
Copy link
Contributor

My only question/comment would be if the current API (as cloudevents.sdk.??? with base, http, etc) is the API that you want to publish for v1.0. (You can always ship a v2.0, and I think the Go API has already done so, so perhaps having something published as v1.0 and then cleaning up from there makes sense.)

@cumason123
Copy link
Contributor Author

cumason123 commented Jul 30, 2020

I'm working on a follow-up PR to reduce the import schema from cloudevents.sdk.??? to cloudevents.???. Issue creations are starting to die down so I'm hoping the cloudevents community can provide more feedback before I update the package, but you're correct in stating we can always adjust through later minor version updates.

Feel free to provide more issues/concerns regarding the current API and I'll be sure to implement them.
@evankanderson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants