Removing ContextAttributes enums #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
|
We're actually using them in |
Member
Author
|
How are you using them? They're really necessary? |
pierDipi
reviewed
Nov 18, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
Author
|
@Alfusainey @pierDipi wanna look again at this? I added javadocs + made constants public |
pierDipi
approved these changes
Nov 18, 2020
Alfusainey
added a commit
to Alfusainey/sdk-java
that referenced
this pull request
Nov 24, 2020
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
slinkydeveloper
pushed a commit
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're useless and they're just increasing the size of the sdk