JSON formatter container conversions - #234
Merged
Merged
Conversation
added 2 commits
August 17, 2022 12:47
The method names are consistent with the ones in ProtobufEventFormatter. Currently batch conversion is not supported, but we can add that later if requested. Signed-off-by: Jon Skeet <jonskeet@google.com>
The method names are consistent with the ones in ProtobufEventFormatter and the Json.NET event formatter. Currently batch conversion is not supported, but we can add that later if requested. The ConvertToJsonElement method is horribly inefficient at the moment (serialize then parse); we can consider how to make it more efficient later if necessary. Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
force-pushed
the
container-conversion
branch
from
August 17, 2022 11:48
2aa7819 to
8d7f8e0
Compare
JoshLove-msft
approved these changes
Aug 18, 2022
jskeet
pushed a commit
to jskeet/sdk-csharp
that referenced
this pull request
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
Merged
jskeet
pushed a commit
to jskeet/sdk-csharp
that referenced
this pull request
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
pushed a commit
to jskeet/sdk-csharp
that referenced
this pull request
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
pushed a commit
to jskeet/sdk-csharp
that referenced
this pull request
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236)) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
pushed a commit
that referenced
this pull request
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([#236](#236)) - Feature: Allow empty payloads in Kafka ([#224](#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([#234](#234), part of [#231](#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([#226](#226), fixes [#225](#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([#220](#220), fixes [#219](#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([#222](#222), fixes [#221](#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([#223](#223), fixes [#175](#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
syed-rizvi-ds
added a commit
to syed-rizvi-ds/CSharp-sdk-dev
that referenced
this pull request
May 13, 2024
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([#236](cloudevents/sdk-csharp#236)) - Feature: Allow empty payloads in Kafka ([#224](cloudevents/sdk-csharp#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([#234](cloudevents/sdk-csharp#234), part of [#231](cloudevents/sdk-csharp#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([#226](cloudevents/sdk-csharp#226), fixes [#225](cloudevents/sdk-csharp#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([#220](cloudevents/sdk-csharp#220), fixes [#219](cloudevents/sdk-csharp#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([#222](cloudevents/sdk-csharp#222), fixes [#221](cloudevents/sdk-csharp#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([#223](cloudevents/sdk-csharp#223), fixes [#175](cloudevents/sdk-csharp#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards #231