Remove deadcode from frontend - Part 1

Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224
Reviewed-on: http://gerrit.cloudera.org:8080/6172
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Reviewed-by: Ravi Shetye <ravi@cloudera.com>
Tested-by: Impala Public Jenkins

Author: Bharath Vissapragada

fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java

@@ -266,7 +266,6 @@ private void createDistinctAggInfo(
   public AggregateInfo getSecondPhaseDistinctAggInfo() {
     return secondPhaseDistinctAggInfo_;
   }
-  public AggPhase getAggPhase() { return aggPhase_; }
   public boolean isMerge() { return aggPhase_.isMerge(); }
   public boolean isDistinctAgg() { return secondPhaseDistinctAggInfo_ != null; }
   public ExprSubstitutionMap getIntermediateSmap() { return intermediateTupleSmap_; }
@@ -297,22 +296,6 @@ public ArrayList<FunctionCallExpr> getMaterializedAggregateExprs() {
     return result;
   }
 
-  /**
-   * Append ids of all slots that are being referenced in the process
-   * of performing the aggregate computation described by this AggregateInfo.
-   */
-  public void getRefdSlots(List<SlotId> ids) {
-    Preconditions.checkState(outputTupleDesc_ != null);
-    if (groupingExprs_ != null) {
-      Expr.getIds(groupingExprs_, null, ids);
-    }
-    Expr.getIds(aggregateExprs_, null, ids);
-    // The backend assumes that the entire aggTupleDesc is materialized
-    for (int i = 0; i < outputTupleDesc_.getSlots().size(); ++i) {
-      ids.add(outputTupleDesc_.getSlots().get(i).getId());
-    }
-  }
-
   /**
    * Substitute all the expressions (grouping expr, aggregate expr) and update our
    * substitution map according to the given substitution map:
@@ -717,20 +700,6 @@ public void checkConsistency() {
     }
   }
 
-  /**
-   * Returns DataPartition derived from grouping exprs.
-   * Returns unpartitioned spec if no grouping.
-   * TODO: this won't work when we start supporting range partitions,
-   * because we could derive both hash and order-based partitions
-   */
-  public DataPartition getPartition() {
-    if (groupingExprs_.isEmpty()) {
-      return DataPartition.UNPARTITIONED;
-    } else {
-      return DataPartition.hashPartitioned(groupingExprs_);
-    }
-  }
-
   @Override
   public String debugString() {
     StringBuilder out = new StringBuilder(super.debugString());

fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java

@@ -62,8 +62,6 @@
  * and need to be substituted as such; example: COUNT(COUNT(..)) OVER (..)
  */
 public class AnalyticExpr extends Expr {
-  private final static Logger LOG = LoggerFactory.getLogger(AnalyticExpr.class);
-
   private FunctionCallExpr fnCall_;
   private final List<Expr> partitionExprs_;
   // These elements are modified to point to the corresponding child exprs to keep them

fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java

@@ -125,19 +125,6 @@ private List<Expr> computeCommonPartitionExprs() {
     return result;
   }
 
-  /**
-   * Append ids of all slots that are being referenced in the process
-   * of performing the analytic computation described by this AnalyticInfo.
-   */
-  public void getRefdSlots(List<SlotId> ids) {
-    Preconditions.checkState(intermediateTupleDesc_ != null);
-    Expr.getIds(analyticExprs_, null, ids);
-    // The backend assumes that the entire intermediateTupleDesc is materialized
-    for (SlotDescriptor slotDesc: intermediateTupleDesc_.getSlots()) {
-      ids.add(slotDesc.getId());
-    }
-  }
-
   @Override
   public void materializeRequiredSlots(Analyzer analyzer, ExprSubstitutionMap smap) {
     materializedSlots_.clear();

fe/src/main/java/org/apache/impala/analysis/Analyzer.java

@@ -165,7 +165,6 @@ public void setIsSubquery() {
     isSubquery_ = true;
     globalState_.containsSubquery = true;
   }
-  public boolean isSubquery() { return isSubquery_; }
   public boolean setHasPlanHints() { return globalState_.hasPlanHints = true; }
   public boolean hasPlanHints() { return globalState_.hasPlanHints; }
   public void setIsWithClause() { isWithClause_ = true; }
@@ -316,12 +315,6 @@ public GlobalState(ImpaladCatalog catalog, TQueryCtx queryCtx,
 
   public boolean containsSubquery() { return globalState_.containsSubquery; }
 
-  /**
-   * Helper function to reset the global state information about the existence of
-   * subqueries.
-   */
-  public void resetSubquery() { globalState_.containsSubquery = false; }
-
   // An analyzer stores analysis state for a single select block. A select block can be
   // a top level select statement, or an inline view select block.
   // ancestors contains the Analyzers of the enclosing select blocks of 'this'
@@ -1587,35 +1580,6 @@ public ArrayList<Expr> getBoundPredicates(TupleId destTid) {
     return getBoundPredicates(destTid, new HashSet<SlotId>(), true);
   }
 
-  /**
-   * Modifies the analysis state associated with the rhs table ref of an outer join
-   * to accomodate a join inversion that changes the rhs table ref of the join from
-   * oldRhsTbl to newRhsTbl.
-   * TODO: Revisit this function and how outer joins are inverted. This function
-   * should not be necessary because the semantics of an inverted outer join do
-   * not change. This function will naturally become obsolete when we can transform
-   * outer joins with otherPredicates into inner joins.
-   */
-  public void invertOuterJoinState(TableRef oldRhsTbl, TableRef newRhsTbl) {
-    Preconditions.checkState(oldRhsTbl.getJoinOp().isOuterJoin());
-    // Invert analysis state for an outer join.
-    List<ExprId> conjunctIds =
-        globalState_.conjunctsByOjClause.remove(oldRhsTbl.getId());
-    if (conjunctIds != null) {
-      globalState_.conjunctsByOjClause.put(newRhsTbl.getId(), conjunctIds);
-      for (ExprId eid: conjunctIds) {
-        globalState_.ojClauseByConjunct.put(eid, newRhsTbl);
-      }
-    } else {
-      // An outer join is allowed not to have an On-clause if the rhs table ref is
-      // correlated or relative.
-      Preconditions.checkState(oldRhsTbl.isCorrelated() || oldRhsTbl.isRelative());
-    }
-    for (Map.Entry<TupleId, TableRef> e: globalState_.outerJoinedTupleIds.entrySet()) {
-      if (e.getValue() == oldRhsTbl) e.setValue(newRhsTbl);
-    }
-  }
-
   /**
    * For each equivalence class, adds/removes predicates from conjuncts such that it
    * contains a minimum set of <lhsSlot> = <rhsSlot> predicates that establish the known
@@ -2086,11 +2050,6 @@ public EquivalenceClassId getEquivClassId(SlotId slotId) {
     return globalState_.equivClassBySlotId.get(slotId);
   }
 
-  public Collection<SlotId> getEquivSlots(SlotId slotId) {
-    EquivalenceClassId classId = globalState_.equivClassBySlotId.get(slotId);
-    return globalState_.equivClassMembers.get(classId);
-  }
-
   public ExprSubstitutionMap getEquivClassSmap() { return globalState_.equivClassSmap; }
 
   /**
@@ -2117,27 +2076,6 @@ public boolean equivExprs(Expr e1, Expr e2) {
     return substE1.equals(substE2);
   }
 
-  /**
-   * Removes redundant expressions from exprs based on equivalence classes, as follows:
-   * First, normalizes the exprs using the canonical SlotRef representative of each
-   * equivalence class. Then retains the first original element of exprs that is
-   * non-redundant in the normalized exprs. Returns a new list with the unique exprs.
-   */
-  public List<Expr> removeRedundantExprs(List<Expr> exprs) {
-    List<Expr> result = Lists.newArrayList();
-    List<Expr> normalizedExprs =
-        Expr.substituteList(exprs, globalState_.equivClassSmap, this, false);
-    Preconditions.checkState(exprs.size() == normalizedExprs.size());
-    List<Expr> uniqueExprs = Lists.newArrayList();
-    for (int i = 0; i < normalizedExprs.size(); ++i) {
-      if (!uniqueExprs.contains(normalizedExprs.get(i))) {
-        uniqueExprs.add(normalizedExprs.get(i));
-        result.add(exprs.get(i).clone());
-      }
-    }
-    return result;
-  }
-
   /**
    * Mark predicates as assigned.
    */
@@ -2155,10 +2093,6 @@ public void markConjunctAssigned(Expr conjunct) {
     globalState_.assignedConjuncts.add(conjunct.getId());
   }
 
-  public boolean isConjunctAssigned(Expr conjunct) {
-    return globalState_.assignedConjuncts.contains(conjunct.getId());
-  }
-
   public Set<ExprId> getAssignedConjuncts() {
     return Sets.newHashSet(globalState_.assignedConjuncts);
   }
@@ -2167,19 +2101,6 @@ public void setAssignedConjuncts(Set<ExprId> assigned) {
     globalState_.assignedConjuncts = Sets.newHashSet(assigned);
   }
 
-  /**
-   * Return true if there's at least one unassigned non-auxiliary conjunct.
-   */
-  public boolean hasUnassignedConjuncts() {
-    for (ExprId id: globalState_.conjuncts.keySet()) {
-      if (globalState_.assignedConjuncts.contains(id)) continue;
-      Expr e = globalState_.conjuncts.get(id);
-      if (e.isAuxExpr()) continue;
-      return true;
-    }
-    return false;
-  }
-
   /**
    * Mark all slots that are referenced in exprs as materialized.
    */
@@ -2486,10 +2407,6 @@ public String getTargetDbName(TableName tableName) {
     return tableName.isFullyQualified() ? tableName.getDb() : getDefaultDb();
   }
 
-  public String getTargetDbName(FunctionName fnName) {
-    return fnName.isFullyQualified() ? fnName.getDb() : getDefaultDb();
-  }
-
   /**
    * Returns the fully-qualified table name of tableName. If tableName
    * is already fully qualified, returns tableName.
@@ -2519,12 +2436,6 @@ public void setHasLimitOffsetClause(boolean hasLimitOffset) {
   public List<Expr> getConjuncts() {
     return new ArrayList<Expr>(globalState_.conjuncts.values());
   }
-  public Expr getConjunct(ExprId exprId) {
-    return globalState_.conjuncts.get(exprId);
-  }
-  public Map<TupleId, List<ExprId>> getEqJoinConjuncts() {
-    return globalState_.eqJoinConjuncts;
-  }
 
   public int incrementCallDepth() { return ++callDepth_; }
   public int decrementCallDepth() { return --callDepth_; }

fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java

@@ -44,8 +44,6 @@
  *
  */
 public class BinaryPredicate extends Predicate {
-  private final static Logger LOG = LoggerFactory.getLogger(BinaryPredicate.class);
-
   // true if this BinaryPredicate is inferred from slot equivalences, false otherwise.
   private boolean isInferred_ = false;
 

fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java

@@ -75,5 +75,4 @@ public static CollectionStructType createMapStructType(MapType mapType) {
 
   public StructField getOptionalField() { return optionalField_; }
   public boolean isMapStruct() { return isMapStruct_; }
-  public boolean isArrayStruct() { return !isMapStruct_; }
 }

fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java

@@ -158,23 +158,6 @@ protected void analyzeImpl(Analyzer analyzer) throws AnalysisException {
     selectivity_ = Math.max(0.0, Math.min(1.0, selectivity_));
   }
 
-  /**
-   * Retrieve the slots bound by BinaryPredicate, InPredicate and
-   * CompoundPredicates in the subtree rooted at 'this'.
-   */
-  public ArrayList<SlotRef> getBoundSlots() {
-    ArrayList<SlotRef> slots = Lists.newArrayList();
-    for (int i = 0; i < getChildren().size(); ++i) {
-      if (getChild(i) instanceof BinaryPredicate ||
-          getChild(i) instanceof InPredicate) {
-        slots.add(((Predicate)getChild(i)).getBoundSlot());
-      } else if (getChild(i) instanceof CompoundPredicate) {
-        slots.addAll(((CompoundPredicate)getChild(i)).getBoundSlots());
-      }
-    }
-    return slots;
-  }
-
   /**
    * Negates a CompoundPredicate.
    */

fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java

@@ -58,7 +58,6 @@ public CreateDbStmt(String dbName, String comment, HdfsUri location,
   public String getComment() { return comment_; }
   public String getDb() { return dbName_; }
   public boolean getIfNotExists() { return ifNotExists_; }
-  public HdfsUri getLocation() { return location_; }
 
   @Override
   public String toSql() {

fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java

@@ -83,7 +83,6 @@ protected CreateFunctionStmtBase(FunctionName fnName, FunctionArgs args,
     optArgs_ = optArgs;
   }
 
-  public String getComment() { return optArgs_.get(OptArg.COMMENT); }
   public boolean getIfNotExists() { return ifNotExists_; }
   public boolean hasSignature() { return args_ != null; }
 

fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java

@@ -200,10 +200,7 @@ public String getOwner() {
     return owner_;
   }
 
-  public List<ColumnDef> getColumnDescs() {return columnDefs_; }
-  public String getComment() { return comment_; }
   public boolean getIfNotExists() { return ifNotExists_; }
-  public String getOriginalViewDef() { return originalViewDef_; }
   public String getInlineViewDef() { return inlineViewDef_; }
   public String getTbl() { return tableName_.getTbl(); }
 }

fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java

@@ -76,7 +76,6 @@ public CreateTableLikeStmt(TableName tableName, TableName srcTableName,
   public String getSrcTbl() { return srcTableName_.getTbl(); }
   public boolean isExternal() { return isExternal_; }
   public boolean getIfNotExists() { return ifNotExists_; }
-  public String getComment() { return comment_; }
   public THdfsFileFormat getFileFormat() { return fileFormat_; }
   public HdfsUri getLocation() { return location_; }
 

fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java

@@ -55,7 +55,6 @@ public String toSql() {
   }
 
   public String getDb() { return dbName_; }
-  public TDescribeOutputStyle getOutputStyle() { return outputStyle_; }
 
   @Override
   public void analyze(Analyzer analyzer) throws AnalysisException {

fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java

@@ -101,12 +101,9 @@ public SlotDescriptor copySlotDescriptor(TupleDescriptor dest, SlotDescriptor sr
 
   public TupleDescriptor getTupleDesc(TupleId id) { return tupleDescs_.get(id); }
   public SlotDescriptor getSlotDesc(SlotId id) { return slotDescs_.get(id); }
-  public Collection<TupleDescriptor> getTupleDescs() { return tupleDescs_.values(); }
   public Collection<SlotDescriptor> getSlotDescs() { return slotDescs_.values(); }
-  public TupleId getMaxTupleId() { return tupleIdGenerator_.getMaxId(); }
   public SlotId getMaxSlotId() { return slotIdGenerator_.getMaxId(); }
 
-  public Table getTargetTable() { return targetTable_; }
   public void setTargetTable(Table table) { targetTable_ = table; }
 
   /**
@@ -139,17 +136,6 @@ public void markSlotsMaterialized(List<SlotId> ids) {
     }
   }
 
-  /**
-   * Return all ids in slotIds that belong to tupleId.
-   */
-  public List<SlotId> getTupleSlotIds(List<SlotId> slotIds, TupleId tupleId) {
-    List<SlotId> result = Lists.newArrayList();
-    for (SlotId id: slotIds) {
-      if (getSlotDesc(id).getParent().getId().equals(tupleId)) result.add(id);
-    }
-    return result;
-  }
-
   /**
    * Computes physical layout parameters of all descriptors.
    * Call this only after the last descriptor was added.

fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java

@@ -51,7 +51,6 @@ public DropFunctionStmt(FunctionName fnName, FunctionArgs fnArgs, boolean ifExis
     ifExists_ = ifExists;
   }
 
-  public FunctionName getFunction() { return desc_.getFunctionName(); }
   public boolean getIfExists() { return ifExists_; }
   private boolean hasSignature() { return fnArgs_ != null; }
 

fe/src/main/java/org/apache/impala/analysis/ExistsPredicate.java

@@ -28,8 +28,6 @@
  * Class representing a [NOT] EXISTS predicate.
  */
 public class ExistsPredicate extends Predicate {
-  private final static Logger LOG = LoggerFactory.getLogger(
-      ExistsPredicate.class);
   private boolean notExists_ = false;
 
   public boolean isNotExists() { return notExists_; }