Fixes for molecule on platform role (#3)

* Fixes for molecule on platform role
* Remove dw definition on molecule runtime role

Signed-off-by: Jim Enright <jenright@cloudera.com>

Author: jimright

roles/platform/meta/main.yml

@@ -20,6 +20,7 @@ galaxy_info:
     addition to the CDP services, the role handles the deployment and management
     of the cloud provider artifacts required for CDP operations, e.g. roles, policies.
   company: Cloudera
+  namespace: cloudera
   license: Apache-2.0
 
   min_ansible_version: 2.10

roles/platform/tasks/setup_aws_authz.yml

@@ -66,7 +66,7 @@
   register: __aws_xaccount_policy
 
 - name: Update AWS Cross Account Policy tags
-  when: __plat_aws_policy_tags_list
+  when: __plat_aws_policy_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-policy
     --policy-arn {{ __aws_xaccount_policy.policy.arn }} 
@@ -98,7 +98,7 @@
   delay: "{{ 10 | random(start=3, step=1) }}"
 
 - name: Update AWS Cross Account Role tags
-  when: __plat_aws_role_tags_list
+  when: __plat_aws_role_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-role
     --role-name {{ plat__aws_xaccount_role_name }} 
@@ -132,7 +132,7 @@
   register: __aws_idbroker_assume_role_policy
 
 - name: Update AWS Cross Account Policy tags
-  when: __plat_aws_policy_tags_list
+  when: __plat_aws_policy_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-policy
     --policy-arn {{ __aws_idbroker_assume_role_policy.policy.arn }} 
@@ -169,14 +169,14 @@
   register: __aws_cdp_data_access_policy_info
 
 - name: Update CDP Data Access Policies tags
-  when: __plat_aws_policy_tags_list
+  when: __plat_aws_policy_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-policy
     --policy-arn {{ __aws_cdp_data_policy_tags_item.policy.arn }} 
     --tags {{ __plat_aws_policy_tags_list | join(' ') }}
   loop_control:
     loop_var: __aws_cdp_data_policy_tags_item
-    label: "{{ __aws_cdp_data_policy_tags_item.policy.name }}"
+    label: "{{ __aws_cdp_data_policy_tags_item.policy.policy_name }}"
   loop: "{{ __aws_cdp_data_access_policy_info.results }}"
   register: __aws_idbroker_assume_role_policy_tags
   failed_when: __aws_cdp_data_policy_tags_item.failed
@@ -219,7 +219,7 @@
         - "{{ plat__aws_bucket_access_policy_name }}"
 
 - name: Update AWS Service Role tags
-  when: __plat_aws_role_tags_list
+  when: __plat_aws_role_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-role
     --role-name {{ __aws_service_role_tags_item.iam_role.role_name }} 
@@ -267,7 +267,7 @@
         - "{{ plat__aws_bucket_access_policy_name }}"
 
 - name: Update AWS Data Access Role tags
-  when: __plat_aws_role_tags_list
+  when: __plat_aws_role_tags_list is defined
   ansible.builtin.command: >
     aws iam tag-role
     --role-name {{ __aws_data_access_role_tags_item.iam_role.role_name }} 

roles/runtime/molecule/level0/molecule.yml

@@ -47,31 +47,6 @@ provisioner:
             region: ${FOUNDRY_AWS_REGION:-us-east-2}
         env:
           tunnel: no                   # L0 Networking
-        dw:
-          #force_delete: yes  # Non-force delete is inconsistent until we can filter 'compactor' VWs
-          tags:
-            project: "${FOUNDRY_NAME_PREFIX:-r00}-CDW-testing"
-          definitions:
-            - name: ${FOUNDRY_NAME_PREFIX:-r00}-empty
-            - virtual_warehouses:
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-dbc-default
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-dbc-hive
-                  type: hive
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-dbc-impala
-                  type: impala
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-dbc-autoscale
-                  autoscaling:
-                    min_nodes: 0  
-            - name: ${FOUNDRY_NAME_PREFIX:-r00}-named
-              virtual_warehouses:
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-named-default
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-named-hive
-                  type: hive
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-named-impala
-                  type: impala
-                - name: ${FOUNDRY_NAME_PREFIX:-r00}-named-autoscale
-                  autoscaling:
-                    min_nodes: 0
 verifier:
   name: ansible
 lint: |