Update tests for type, name, and all

Author: wmudge

tests/unit/plugins/modules/service_role_config_group_info/test_service_role_config_group_info.py

@@ -60,45 +60,67 @@ def test_invalid_service(conn, module_args, base_cluster):
         service_role_config_group_info.main()
 
 
-def test_invalid_cluster(conn, module_args, base_cluster, zk_auto):
+def test_invalid_cluster(conn, module_args, base_cluster):
     module_args(
         {
             **conn,
             "cluster": "BOOM",
-            "service": zk_auto.name,
+            "service": "ShouldNotReach",
         }
     )
 
     with pytest.raises(AnsibleFailJson, match="Cluster does not exist: BOOM"):
         service_role_config_group_info.main()
 
 
-def test_view_all_role_config_groups(conn, module_args, base_cluster, zk_auto):
+def test_all_role_config_groups(conn, module_args, base_cluster, zk_auto):
+    module_args(
+        {
+            **conn,
+            "cluster": base_cluster.name,
+            "service": zk_auto.name,
+        }
+    )
+
+    with pytest.raises(AnsibleExitJson) as e:
+        service_role_config_group_info.main()
+
+    # Should be only one BASE for the SERVER
+    assert len(e.value.role_config_groups) == 1
+    assert e.value.role_config_groups[0]["base"] == True
+
+
+def test_type_role_config_group(conn, module_args, base_cluster, zk_auto):
     module_args(
         {
             **conn,
             "cluster": base_cluster.name,
             "service": zk_auto.name,
+            "type": "SERVER",
         }
     )
 
     with pytest.raises(AnsibleExitJson) as e:
         service_role_config_group_info.main()
 
-    assert len(e.value.role_config_groups) > 0
+    # Should be only one BASE for the SERVER
+    assert len(e.value.role_config_groups) == 1
+    assert e.value.role_config_groups[0]["base"] == True
 
 
-def test_view_service_role(conn, module_args, base_cluster, zk_auto):
+def test_name_role_config_group(conn, module_args, base_cluster, zk_auto):
     module_args(
         {
             **conn,
             "cluster": base_cluster.name,
             "service": zk_auto.name,
-            "name": "hdfs-GATEWAY-BASE",
+            "name": "zookeeper-SERVER-BASE",
         }
     )
 
     with pytest.raises(AnsibleExitJson) as e:
         service_role_config_group_info.main()
 
+    # Should be only one BASE for the SERVER
     assert len(e.value.role_config_groups) == 1
+    assert e.value.role_config_groups[0]["base"] == True