alert on subscription failure, and shutdown returns an empty list #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maroux
reviewed
Nov 3, 2022
hedwig/backends/gcp.py
Outdated
| @@ -261,14 +271,24 @@ def pull_messages( | |||
| ) | |||
|
|
|||
| for subscription_path in self._subscription_paths: | |||
| # need a separate scheduler per subscription since the queue is tied to subscription path | |||
There was a problem hiding this comment.
comment is still valid i think
danfischetti
commented
Nov 3, 2022
hedwig/backends/gcp.py
Outdated
| self.shutdown_event = shutdown_event | ||
|
|
||
| def shutdown(self, await_msg_callbacks=False) -> List: # type: ignore | ||
| self.shutdown_event.set() |
There was a problem hiding this comment.
Not sure if setting this shutdown event in the Scheduler is necessary. I think the important bit was to return the empty list instead of None.
maroux
reviewed
Nov 3, 2022
hedwig/backends/gcp.py
Outdated
| self.shutdown_event = shutdown_event | ||
|
|
||
| def shutdown(self, await_msg_callbacks=False) -> List: # type: ignore | ||
| self.shutdown_event.set() |
There was a problem hiding this comment.
hm not sure how I feel about this - the event is technically just an input to this class and owned by the caller. I'd rather we raise an exception here and let caller deal with that instead of this - thoughts?
There was a problem hiding this comment.
Yeah, I dont think we need this shutdown event here
maroux
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.