Skip to content

Commit 1a15c05

Browse files
authored
Merge pull request #186 from cloudblue/minor-fixes
LITE-25710: Fix minor bootstraping issues
2 parents a8705e9 + f426932 commit 1a15c05

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

connect/cli/plugins/project/extension/templates/bootstrap/${project_slug}/${package_name}/schemas.py.j2

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
1-
from typing import List
1+
from typing import List, Optional
22

3-
from pydantic import BaseModel
3+
from pydantic import BaseModel, validator
44

55

66
class Marketplace(BaseModel):
77
id: str
88
name: str
99
description: str
10-
icon: str = (
11-
'https://unpkg.com/@cloudblueconnect'
12-
'/material-svg@latest/icons/google/language/baseline.svg'
13-
)
10+
icon: Optional[str]
11+
12+
@validator('icon')
13+
def set_icon(cls, icon):
14+
return icon or (
15+
'https://unpkg.com/@cloudblueconnect'
16+
'/material-svg@latest/icons/google/language/baseline.svg'
17+
)
1418

1519

1620
class Settings(BaseModel):

connect/cli/plugins/project/extension/templates/bootstrap/${project_slug}/HOWTO.md.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $ docker compose up {{ project_slug }}_dev
2525
If you would like to develop and test at the same time, we recommend you run your project using the command:
2626

2727
```sh
28-
$ docker compose up {{ project_slug }}_bash
28+
$ docker compose run {{ project_slug }}_bash
2929
```
3030

3131
Once you get the interactive shell an help banner will be displayed to inform you about the included tools that can help you with the development of your extension.
@@ -34,7 +34,7 @@ Once you get the interactive shell an help banner will be displayed to inform yo
3434
Additionally, a basic boilerplate for writing unit tests has been created, you can run the tests using:
3535

3636
```sh
37-
$ docker compose up {{ project_slug }}_test
37+
$ docker compose run {{ project_slug }}_test
3838
```
3939

4040

0 commit comments

Comments
 (0)