fix: remove unnecessary github api call #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only a few cases, where we get a job information from github where the runner name is not set. For all this cases we do not need to check github API at all because these jobs are never ever get scheduled to a runner: job.Action is: * queued: a queued job is just queued and not scheduled to a runner so we do not get a runner name from the GH API * completed: when conclusion=cancelled|failure github never scheduled the job to a runner and with that we do not get a runner name from the GH API Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
gabriel-samfira
approved these changes
Jun 5, 2024
Member
|
Could you add a check here: Line 212 in 02ff74b For the runner name. And just log that there was no runner assigned and just return nil. Saves us some unnecessary db queries and log spam |
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
added a commit
to mercedes-benz/garm
that referenced
this pull request
Jun 5, 2024
from cloudbase#255 Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only a few cases, where we get a job information from github where the runner name is not set.
For all this cases we do not need to check github API at all because these jobs are never ever get scheduled to a runner:
job.Action is: