Fix nil pointer dereference

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>

Author: gabriel-samfira

cmd/garm-cli/cmd/github_credentials.go

@@ -15,8 +15,6 @@
 package cmd
 
 import (
-	"crypto/x509"
-	"encoding/pem"
 	"fmt"
 	"os"
 	"strconv"
@@ -260,20 +258,20 @@ func init() {
 }
 
 func parsePrivateKeyFromPath(path string) ([]byte, error) {
-	if _, err := os.Stat(path); err != nil {
-		return nil, fmt.Errorf("private key file not found: %s", credentialsPrivateKeyPath)
-	}
+	// if _, err := os.Stat(path); err != nil {
+	// 	return nil, fmt.Errorf("private key file not found: %s", credentialsPrivateKeyPath)
+	// }
 	keyContents, err := os.ReadFile(path)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read private key file: %w", err)
 	}
-	pemBlock, _ := pem.Decode(keyContents)
-	if pemBlock == nil {
-		return nil, fmt.Errorf("failed to decode PEM block")
-	}
-	if _, err := x509.ParsePKCS1PrivateKey(pemBlock.Bytes); err != nil {
-		return nil, fmt.Errorf("failed to parse private key: %w", err)
-	}
+	// pemBlock, _ := pem.Decode(keyContents)
+	// if pemBlock == nil {
+	// 	return nil, fmt.Errorf("failed to decode PEM block")
+	// }
+	// if _, err := x509.ParsePKCS1PrivateKey(pemBlock.Bytes); err != nil {
+	// 	return nil, fmt.Errorf("failed to parse private key: %w", err)
+	// }
 	return keyContents, nil
 }
 

params/requests.go

@@ -424,6 +424,9 @@ func (g GithubApp) Validate() error {
 	}
 
 	block, _ := pem.Decode(g.PrivateKeyBytes)
+	if block == nil {
+		return runnerErrors.NewBadRequestError("invalid private_key_bytes")
+	}
 	// Parse the private key as PCKS1
 	_, err := x509.ParsePKCS1PrivateKey(block.Bytes)
 	if err != nil {