fix: use explicit lifetimes at new functions

Author: d-kuen

src/address.rs

@@ -13,7 +13,7 @@ pub struct Address<'a> {
 }
 
 impl<'a> Address<'a> {
-    pub fn new(name: &'a str, town: &'a str, zip: &'a str, country: &'a str) -> Address<'a> {
+    pub fn new(name: &'a str, town: &'a str, zip: &'a str, country: &'a str) -> Self {
         Address {
             name,
             town,

src/biller.rs

@@ -16,7 +16,7 @@ pub struct Biller<'a> {
 }
 
 impl<'a> Biller<'a> {
-    pub fn new(vat_identification_number: &str) -> Biller {
+    pub fn new(vat_identification_number: &'a str) -> Self {
         Biller {
             vat_identification_number,
             ..Default::default()

src/contact.rs

@@ -9,7 +9,7 @@ pub struct Contact<'a> {
 }
 
 impl<'a> Contact<'a> {
-    pub fn new(name: &str) -> Contact {
+    pub fn new(name: &'a str) -> Self {
         Contact {
             name,
             ..Default::default()

src/details.rs

@@ -22,12 +22,7 @@ pub struct DetailsItem<'a> {
 }
 
 impl<'a> DetailsItem<'a> {
-    pub fn new(
-        quantity: Decimal,
-        unit: &'a str,
-        unit_price: Decimal,
-        tax_item: TaxItem,
-    ) -> DetailsItem<'a> {
+    pub fn new(quantity: Decimal, unit: &'a str, unit_price: Decimal, tax_item: TaxItem) -> Self {
         DetailsItem {
             quantity,
             unit,

src/identification.rs

@@ -48,8 +48,8 @@ pub struct FurtherIdentification<'a> {
     id_type: FurtherIdentificationType,
 }
 
-impl FurtherIdentification<'_> {
-    pub fn new(id: &str, id_type: FurtherIdentificationType) -> FurtherIdentification {
+impl<'a> FurtherIdentification<'a> {
+    pub fn new(id: &'a str, id_type: FurtherIdentificationType) -> Self {
         FurtherIdentification { id, id_type }
     }
 }

src/invoice_recipient.rs

@@ -16,7 +16,7 @@ pub struct InvoiceRecipient<'a> {
 }
 
 impl<'a> InvoiceRecipient<'a> {
-    pub fn new(vat_identification_number: &str) -> InvoiceRecipient {
+    pub fn new(vat_identification_number: &'a str) -> Self {
         InvoiceRecipient {
             vat_identification_number,
             ..Default::default()

src/order_reference.rs

@@ -8,7 +8,7 @@ pub struct OrderReference<'a> {
 }
 
 impl<'a> OrderReference<'a> {
-    pub fn new(order_id: &str) -> OrderReference {
+    pub fn new(order_id: &'a str) -> Self {
         OrderReference {
             order_id,
             ..Default::default()

src/payment_method.rs

@@ -53,7 +53,7 @@ trait MatchBicRegex {
 impl MatchBicRegex for PaymentMethodSEPADirectDebit<'_> {}
 
 impl<'a> PaymentMethodSEPADirectDebit<'a> {
-    pub fn new() -> PaymentMethodSEPADirectDebit<'a> {
+    pub fn new() -> Self {
         PaymentMethodSEPADirectDebit {
             ..Default::default()
         }
@@ -163,10 +163,7 @@ pub struct PaymentMethodUniversalBankTransactionBeneficiaryAccountBankCode<'a> {
 }
 
 impl<'a> PaymentMethodUniversalBankTransactionBeneficiaryAccountBankCode<'a> {
-    pub fn new(
-        bank_code: i64,
-        bank_code_type: &'a str,
-    ) -> PaymentMethodUniversalBankTransactionBeneficiaryAccountBankCode<'a> {
+    pub fn new(bank_code: i64, bank_code_type: &'a str) -> Self {
         PaymentMethodUniversalBankTransactionBeneficiaryAccountBankCode {
             bank_code,
             bank_code_type,
@@ -187,7 +184,7 @@ pub struct PaymentMethodUniversalBankTransactionBeneficiaryAccount<'a> {
 impl MatchBicRegex for PaymentMethodUniversalBankTransactionBeneficiaryAccount<'_> {}
 
 impl<'a> PaymentMethodUniversalBankTransactionBeneficiaryAccount<'a> {
-    pub fn new() -> PaymentMethodUniversalBankTransactionBeneficiaryAccount<'a> {
+    pub fn new() -> Self {
         PaymentMethodUniversalBankTransactionBeneficiaryAccount {
             ..Default::default()
         }
@@ -292,7 +289,7 @@ pub struct PaymentMethodUniversalBankTransaction<'a> {
 }
 
 impl<'a> PaymentMethodUniversalBankTransaction<'a> {
-    pub fn new() -> PaymentMethodUniversalBankTransaction<'a> {
+    pub fn new() -> Self {
         PaymentMethodUniversalBankTransaction {
             ..Default::default()
         }
@@ -366,7 +363,7 @@ pub struct PaymentMethodPaymentCard<'a> {
 }
 
 impl<'a> PaymentMethodPaymentCard<'a> {
-    pub fn new(primary_account_number: &'a str) -> Result<PaymentMethodPaymentCard<'a>, String> {
+    pub fn new(primary_account_number: &'a str) -> Result<Self, String> {
         static PAYMENT_CARD_REGEX_STR: &str = r"^[0-9]{0,6}\*[0-9]{0,4}$";
         static PAYMENT_CARD_REGEX: LazyLock<Regex> =
             LazyLock::new(|| Regex::new(PAYMENT_CARD_REGEX_STR).unwrap());

src/reduction_and_surcharge.rs

@@ -18,10 +18,7 @@ struct ReductionAndSurchargeListLineItemBase<'a> {
 }
 
 impl<'a> ReductionAndSurchargeListLineItemBase<'a> {
-    fn new(
-        base_amount: Decimal,
-        value: ReductionAndSurchargeValue,
-    ) -> ReductionAndSurchargeListLineItemBase<'a> {
+    fn new(base_amount: Decimal, value: ReductionAndSurchargeValue) -> Self {
         ReductionAndSurchargeListLineItemBase {
             base_amount,
             value,
@@ -42,8 +39,10 @@ impl<'a> ReductionAndSurchargeListLineItemBase<'a> {
     }
 
     fn to_xml_elements(&self) -> Vec<XmlElement> {
-        let mut es = vec![XmlElement::new("BaseAmount")
-            .with_text(self.base_amount.clone_with_scale(2).to_string())];
+        let mut es = vec![
+            XmlElement::new("BaseAmount")
+                .with_text(self.base_amount.clone_with_scale(2).to_string()),
+        ];
 
         match self.value {
             ReductionAndSurchargeValue::Percentage(percentage) => {
@@ -149,7 +148,7 @@ pub struct ReductionAndSurchargeListLineItemDetails<'a> {
 }
 
 impl<'a> ReductionAndSurchargeListLineItemDetails<'a> {
-    pub fn new() -> ReductionAndSurchargeListLineItemDetails<'a> {
+    pub fn new() -> Self {
         ReductionAndSurchargeListLineItemDetails {
             ..Default::default()
         }

src/tax.rs

@@ -52,7 +52,7 @@ pub struct TaxItem {
 }
 
 impl TaxItem {
-    pub fn new(tax_percent: Decimal, tax_category: TaxCategory) -> TaxItem {
+    pub fn new(tax_percent: Decimal, tax_category: TaxCategory) -> Self {
         TaxItem {
             tax_percent,
             tax_category,