Support current versions of Node.js #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlipper
changed the title
Member
|
Thanks for submitting this @phlipper! Wouldnt it make more sense to handle the different versions via an ENV var (instead of multiple snippets per version?) |
Author
|
@lvangool I was following the convention of the existing files, but I would be happy to collapse all of those down into a single script which can utilize an ENV var if you'd prefer. |
Member
|
@phlipper Got it! Yes that would be great to collapse them down. |
|
Is there a way to handle the different versions via ENV now? or was it never implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds snippets for installing Node.js versions
6.xand7.x, including support for updating from previous versions if present.